GNU bug report logs - #22620
24.5; "(global-hi-lock-mode 1)" broke "C-x" key bindings inside "M-x term", especially for "emacs -nw" (Emacs inside Emacs).

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22620 in the body.
You can then email your comments to 22620 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleksandr Gavenko <gavenkoa <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5;
 "(global-hi-lock-mode 1)" broke "C-x" key bindings inside "M-x term",
 especially for "emacs -nw" (Emacs inside Emacs).
Date: Wed, 10 Feb 2016 19:56:34 +0200

In GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.18.2)
 of 2015-10-24 on trouble, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.11702000
System Description:	Debian GNU/Linux testing (stretch)

I use convenient script for invoking Emacs in terminal as if it was "vi"
(because I hate a way vi works):

  http://hg.defun.work/utils/file/tip/emacs/e

which is actually call:

  emacsclient -t

Today I try to use "hg record" to select diff hunks manually inside M-x term
(instead of xterm).

My EDITOR=et which is above "emacsclient -t".

After entering to Emacs inside Emacs terminal emulation I can't save file or
iterate over buffers. For all commands with "C-x" prefix I see:

  C-x C-s is undefined
  C-x C-c is undefined

in outer Emacs (that was in X Window). So key sequences doesn't reach Emacs
inside Emacs terminal emulator.

After bisecting I found that with X Emacs:

  $ emacs -q

after evaluating:

  (global-hi-lock-mode 1)

and entering to "M-x term" Emacs in term-mode can't handle "C-x" sequences.

My 3 kLOC .emacs file with commented:

  (global-hi-lock-mode 1)

work fine.

-- 
http://defun.work/

Message #8 received at 22620 <at> debbugs.gnu.org (full text, mbox):

From: Oleksandr Gavenko <gavenkoa <at> gmail.com>
To: help-debbugs <at> gnu.org (GNU bug Tracking System)
Cc: 22620 <at> debbugs.gnu.org
Subject: Re: bug#22620: Acknowledgement (24.5;
 "(global-hi-lock-mode 1)" broke "C-x" key bindings inside "M-x term",
 especially for "emacs -nw" (Emacs inside Emacs).)
Date: Wed, 10 Feb 2016 22:19:43 +0200

After:

  (global-hi-lock-mode 1)

this:

  (global-hi-lock-mode -1)

restore behavior. Repeating:

  (global-hi-lock-mode 1)

again broke "C-x" prefix.

-- 
http://defun.work/

Message #11 received at 22620 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Oleksandr Gavenko <gavenkoa <at> gmail.com>
Cc: 22620 <at> debbugs.gnu.org
Subject: Re: bug#22620: 24.5;
 "(global-hi-lock-mode 1)" broke "C-x" key bindings inside "M-x term",
 especially for "emacs -nw" (Emacs inside Emacs).
Date: Fri, 26 Jul 2019 23:49:18 -0400

tags 22620 + confirmed
found 22620 26.2
quit

Oleksandr Gavenko <gavenkoa <at> gmail.com> writes:

>   (global-hi-lock-mode 1)
>
> again broke "C-x" prefix.

Yes, the problem is that hi-lock-mode defines keys using the C-x prefix,
and it is a minor mode so it overrides term.el's major mode binding of
C-x to term-send-raw.  It's not immediately clear to me what the correct
fix is though.

I guess we could add term-mode to hi-lock-exclude-modes?

Message #18 received at 22620 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 22620 <at> debbugs.gnu.org, Oleksandr Gavenko <gavenkoa <at> gmail.com>
Subject: Re: bug#22620: 24.5; "(global-hi-lock-mode 1)" broke "C-x" key
 bindings inside "M-x term", especially for "emacs -nw" (Emacs inside
 Emacs).
Date: Thu, 08 Jul 2021 03:25:06 +0200

Noam Postavsky <npostavs <at> gmail.com> writes:

> Oleksandr Gavenko <gavenkoa <at> gmail.com> writes:
>
>>   (global-hi-lock-mode 1)
>>
>> again broke "C-x" prefix.
>
> Yes, the problem is that hi-lock-mode defines keys using the C-x prefix,
> and it is a minor mode so it overrides term.el's major mode binding of
> C-x to term-send-raw.  It's not immediately clear to me what the correct
> fix is though.
>
> I guess we could add term-mode to hi-lock-exclude-modes?

Yup.  I did that in Emacs 28, and it made the problem go away.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.