GNU bug report logs - #22616
25.0.50; Change to lm-header breaks lm-header-multiline

Previous Next

Package: emacs;

Reported by: Jonas Bernoulli <jonas <at> bernoul.li>

Date: Wed, 10 Feb 2016 16:18:02 UTC

Severity: normal

Merged with 22510

Found in versions 25.0.50, 25.1.50

Fixed in version 25.1

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Artur Malabarba <bruce.connor.am <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>, Jonas Bernoulli <jonas <at> bernoul.li>, 22616 <at> debbugs.gnu.org
Subject: bug#22616: 25.0.50; Change to lm-header breaks lm-header-multiline
Date: Mon, 09 May 2016 02:13:24 +0000
[Message part 1 (text/plain, inline)]
IIRC, I made this change because the previous behaviour caused
`package-install-from-buffer' to move point. Since I saw no reason for
lm-header to move point, I fixed the issue at its roots.
Clearly, we've found a reason now. So the save excursion should be removed
from the latter function to the former.

On Sun, 8 May 2016 8:52 pm Dmitry Gutov, <dgutov <at> yandex.ru> wrote:

> Arthur,
>
> could you look into this one? And at the bug#22510 merged with it.
>
> Do you remember why you made this change?
>
> On 02/10/2016 06:17 PM, Jonas Bernoulli wrote:
> > Starting with bf3f6a961f378f35a292c41c0bfbdae88ee1b1b9 `lm-header's body
> > is wrapped with `save-excursion', but `lm-header-multiline' only works
> > properly if `lm-header' doesn't do that.
> >
> > In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.25)
> >  of 2016-01-28 built on hal
> > Repository revision: 9be8a2fb41043b4d4734a67f155d6923df10671b
>
[Message part 2 (text/html, inline)]

This bug report was last modified 9 years and 11 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.