GNU bug report logs - #22616
25.0.50; Change to lm-header breaks lm-header-multiline

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22616 in the body.
You can then email your comments to 22616 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonas Bernoulli <jonas <at> bernoul.li>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; Change to lm-header breaks lm-header-multiline
Date: Wed, 10 Feb 2016 17:17:15 +0100

Starting with bf3f6a961f378f35a292c41c0bfbdae88ee1b1b9 `lm-header's body
is wrapped with `save-excursion', but `lm-header-multiline' only works
properly if `lm-header' doesn't do that.

In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.25)
 of 2016-01-28 built on hal
Repository revision: 9be8a2fb41043b4d4734a67f155d6923df10671b

Message #12 received at 22616 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Jonas Bernoulli <jonas <at> bernoul.li>, 22616 <at> debbugs.gnu.org
Cc: Artur Malabarba <bruce.connor.am <at> gmail.com>
Subject: Re: bug#22616: 25.0.50; Change to lm-header breaks lm-header-multiline
Date: Mon, 9 May 2016 02:52:27 +0300

Arthur,

could you look into this one? And at the bug#22510 merged with it.

Do you remember why you made this change?

On 02/10/2016 06:17 PM, Jonas Bernoulli wrote:
> Starting with bf3f6a961f378f35a292c41c0bfbdae88ee1b1b9 `lm-header's body
> is wrapped with `save-excursion', but `lm-header-multiline' only works
> properly if `lm-header' doesn't do that.
>
> In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.25)
>  of 2016-01-28 built on hal
> Repository revision: 9be8a2fb41043b4d4734a67f155d6923df10671b

Message #15 received at 22616 <at> debbugs.gnu.org (full text, mbox):

From: Artur Malabarba <bruce.connor.am <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>, Jonas Bernoulli <jonas <at> bernoul.li>,
 22616 <at> debbugs.gnu.org
Subject: Re: bug#22616: 25.0.50; Change to lm-header breaks lm-header-multiline
Date: Mon, 09 May 2016 02:13:24 +0000

[Message part 1 (text/plain, inline)]

IIRC, I made this change because the previous behaviour caused
`package-install-from-buffer' to move point. Since I saw no reason for
lm-header to move point, I fixed the issue at its roots.
Clearly, we've found a reason now. So the save excursion should be removed
from the latter function to the former.

On Sun, 8 May 2016 8:52 pm Dmitry Gutov, <dgutov <at> yandex.ru> wrote:

> Arthur,
>
> could you look into this one? And at the bug#22510 merged with it.
>
> Do you remember why you made this change?
>
> On 02/10/2016 06:17 PM, Jonas Bernoulli wrote:
> > Starting with bf3f6a961f378f35a292c41c0bfbdae88ee1b1b9 `lm-header's body
> > is wrapped with `save-excursion', but `lm-header-multiline' only works
> > properly if `lm-header' doesn't do that.
> >
> > In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.25)
> >  of 2016-01-28 built on hal
> > Repository revision: 9be8a2fb41043b4d4734a67f155d6923df10671b
>

[Message part 2 (text/html, inline)]

Message #18 received at 22616 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Artur Malabarba <bruce.connor.am <at> gmail.com>,
 Jonas Bernoulli <jonas <at> bernoul.li>, 22616 <at> debbugs.gnu.org
Subject: Re: bug#22616: 25.0.50; Change to lm-header breaks lm-header-multiline
Date: Wed, 11 May 2016 03:00:22 +0300

On 05/09/2016 05:13 AM, Artur Malabarba wrote:
> IIRC, I made this change because the previous behaviour caused
> `package-install-from-buffer' to move point. Since I saw no reason for
> lm-header to move point, I fixed the issue at its roots.

Doesn't package-install-from-buffer currently move point anyway? It 
jumps to the end of the buffer.

Moving save-excursion there does help.

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 3f0e972..f481157 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1979,17 +1979,18 @@ package-install-from-buffer
 Downloads and installs required packages as needed."
   (interactive)
   (let* ((pkg-desc
-          (cond
-            ((derived-mode-p 'dired-mode)
-             ;; This is the only way a package-desc object with a `dir'
-             ;; desc-kind can be created.  Such packages can't be
-             ;; uploaded or installed from archives, they can only be
-             ;; installed from local buffers or directories.
-             (package-dir-info))
-            ((derived-mode-p 'tar-mode)
-             (package-tar-file-info))
-            (t
-             (package-buffer-info))))
+          (save-excursion
+            (cond
+             ((derived-mode-p 'dired-mode)
+              ;; This is the only way a package-desc object with a `dir'
+              ;; desc-kind can be created.  Such packages can't be
+              ;; uploaded or installed from archives, they can only be
+              ;; installed from local buffers or directories.
+              (package-dir-info))
+             ((derived-mode-p 'tar-mode)
+              (package-tar-file-info))
+             (t
+              (package-buffer-info)))))
          (name (package-desc-name pkg-desc)))
     ;; Download and install the dependencies.
     (let* ((requires (package-desc-reqs pkg-desc))

Message #23 received at 22616-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Artur Malabarba <bruce.connor.am <at> gmail.com>,
 Jonas Bernoulli <jonas <at> bernoul.li>, 22616-done <at> debbugs.gnu.org
Subject: Re: bug#22616: 25.0.50; Change to lm-header breaks lm-header-multiline
Date: Thu, 12 May 2016 01:34:44 +0300

Version: 25.1

On 05/11/2016 03:00 AM, Dmitry Gutov wrote:

> Moving save-excursion there does help.

Applied, and closing.

Thanks all.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.