GNU bug report logs - #22167
Invalid token errors with resizepart

Previous Next

To reply to this bug, email your comments to 22167 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julius Schwartzenberg <julius.schwartzenberg <at> abz.nl>
To: <bug-parted <at> gnu.org>
Subject: Invalid token errors with resizepart
Date: Mon, 14 Dec 2015 16:52:08 +0100

Hi,

I'm trying to create a single command to increase a single root 
partition to the maximum size. Doing it step by step, I managed to do it 
interactively with:
> (parted) resizepart 1
> Warning: Partition /dev/vda1 is being used. Are you sure you want to continue?
> Yes/No? yes
> End?  [4000MB]? -1s

When I do it all on a single line, I get an error that -1s is an invalid 
token however:
> (parted) resizepart 1 -1s
> Warning: Partition /dev/vda1 is being used. Are you sure you want to continue?
> parted: invalid token: -1s

I tried other values as well, but it seems the end argument can't be 
parsed properly when it's specified with the initial call or I'm doing 
something wrong. Is there any way to get this to work?

I'm using GNU Parted 3.2 as shipped with Fedora 22.

Thanks in advance!

Best regards,
Julius

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: bug-parted <at> gnu.org
Subject: Re: bug#22167: Invalid token errors with resizepart
Date: Mon, 14 Dec 2015 13:48:05 -0800

On Mon, Dec 14, 2015 at 04:52:08PM +0100, Julius Schwartzenberg wrote:
> Hi,
> 
> I'm trying to create a single command to increase a single root partition to
> the maximum size. Doing it step by step, I managed to do it interactively
> with:
> >(parted) resizepart 1
> >Warning: Partition /dev/vda1 is being used. Are you sure you want to continue?
> >Yes/No? yes
> >End?  [4000MB]? -1s
> 
> When I do it all on a single line, I get an error that -1s is an invalid
> token however:
> >(parted) resizepart 1 -1s
> >Warning: Partition /dev/vda1 is being used. Are you sure you want to continue?
> >parted: invalid token: -1s
> 
> I tried other values as well, but it seems the end argument can't be parsed
> properly when it's specified with the initial call or I'm doing something
> wrong. Is there any way to get this to work?

You need to make sure the partition isn't mounted.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Message #11 received at 22167 <at> debbugs.gnu.org (full text, mbox):

From: Sunil Mohan Adapa <sunil <at> medhas.org>
To: 24215 <at> debbugs.gnu.org, 22167 <at> debbugs.gnu.org, control <at> debbugs.gnu.org
Subject: Don't interactively ask questions in script mode
Date: Mon, 3 Apr 2017 15:30:29 +0530

[Message part 1 (text/plain, inline)]

tags 24215 + patch
tags 22167 + patch

Hello,

The attached patches should fix these issues where interactive prompts
are shown when one tries to perform 'rm' or 'resizepart' operations with
mounted partitions.  This avoid workarounds[1].

The proposal is to not ask for confirmation during 'rm' and 'resizepart'
operations when run in script mode.  The answer is assumed to be 'yes'
in both cases.

Links:

1) https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1270203

-- 
Sunil

[0001-parted-Don-t-warn-partition-busy-in-script-mode.patch (text/x-patch, attachment)]

[0002-tests-t1701-rescue-fs.sh-Wait-for-device-to-appear.patch (text/x-patch, attachment)]

[0003-tests-t1101-busy-partition.sh-Update-tests-for-scrip.patch (text/x-patch, attachment)]

[0004-tests-t6002-Fix-expectation-of-rm-on-mounted-partiti.patch (text/x-patch, attachment)]

[0005-tests-t9041-Fix-expectation-of-rm-on-mounted-partiti.patch (text/x-patch, attachment)]

[0006-tests-t1102-Fix-expectation-of-rm-on-mounted-partiti.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #16 received at 22167 <at> debbugs.gnu.org (full text, mbox):

From: Sunil Mohan Adapa <sunil <at> medhas.org>
To: 22167 <at> debbugs.gnu.org, control <at> debbugs.gnu.org
Subject: Re: Don't interactively ask questions in script mode
Date: Mon, 3 Apr 2017 21:09:51 +0530

[Message part 1 (text/plain, inline)]

tags 22167 - patch
thanks

Sorry, my patches don't solve this problem which seems unrelated.  They
are only applicable for scripted mode.

On 04/03/2017 03:30 PM, Sunil Mohan Adapa wrote:
> 
> Hello,
> 
> The attached patches should fix these issues where interactive prompts
> are shown when one tries to perform 'rm' or 'resizepart' operations with
> mounted partitions.  This avoid workarounds[1].
> 
> The proposal is to not ask for confirmation during 'rm' and 'resizepart'
> operations when run in script mode.  The answer is assumed to be 'yes'
> in both cases.
> 
> Links:
> 
> 1) https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1270203
> 

[signature.asc (application/pgp-signature, attachment)]

Message #23 received at 22167 <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: Sunil Mohan Adapa <sunil <at> medhas.org>
Cc: 22167 <at> debbugs.gnu.org, 24215 <at> debbugs.gnu.org
Subject: Re: Don't interactively ask questions in script mode
Date: Mon, 6 Jan 2020 14:40:23 -0800

On Tue, Dec 31, 2019 at 05:21:11PM -0800, Sunil Mohan Adapa wrote:
> Hello,
> 
> Any updates on this bug or comments on the patches? I believe the fix is
> straight forward and correct.

Do you mean these?

https://lists.gnu.org/archive/html/bug-parted/2017-04/msg00000.html

I really cannot think of a good reason to remove or resize a mounted
partition. Why not unmount it first and avoid the issue completely?

-- 
Brian C. Lane (PST8PDT) - weldr.io - lorax - parted - pykickstart

Message #26 received at 22167 <at> debbugs.gnu.org (full text, mbox):

From: Sunil Mohan Adapa <sunil <at> medhas.org>
To: "Brian C. Lane" <bcl <at> redhat.com>
Cc: 22167 <at> debbugs.gnu.org, 24215 <at> debbugs.gnu.org
Subject: Re: Don't interactively ask questions in script mode
Date: Tue, 7 Jan 2020 15:05:24 -0800

[Message part 1 (text/plain, inline)]

On 06/01/20 2:40 pm, Brian C. Lane wrote:
> On Tue, Dec 31, 2019 at 05:21:11PM -0800, Sunil Mohan Adapa wrote:
>> Hello,
>>
>> Any updates on this bug or comments on the patches? I believe the fix is
>> straight forward and correct.
> 
> Do you mean these?
> 
> https://lists.gnu.org/archive/html/bug-parted/2017-04/msg00000.html

Indeed, it seems likes the original implementation simply missed out on
these checks judging by how other cases were handled and how --script
option is documented.

Some of the updates to test cases included in these patches may have
been handled with recent changes.

> 
> I really cannot think of a good reason to remove or resize a mounted
> partition. Why not unmount it first and avoid the issue completely?
> 
This is a very common scenario when running on single board computers.
Disk images from the OS vendors are downloaded and written to SD cards
(or eMMC) instead of a typical installation wizard process. These images
are of a fixed size, say 4GiB, and when the OS boots for the first time,
the last partition is expanded to take up the full size of the disk
(typically more than 32GB). After this the users get to use the full
storage capacity of the disk.

This operation is done by many OS images meant for Raspberry Pi. In my
case it is FreedomBox[1], a pure blend of Debian for home servers
running on cheap hardware. It is likely that all of these users are
avoiding parted for this operation or working around the problem.

Since online expansion is supported by many file systems including ext4
and btrfs, when using the underlying tools, I don't see a reason for
parted to refuse to do this. Also, since the operation is currently
allowed to be performed manually, scripts should have ability to do the
same, given that they know that it is safe.

Links:

1) https://freedombox.org

-- 
Sunil

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.