GNU bug report logs - #2209
23.0.90; copyright-update might not update copyright

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2209 in the body.
You can then email your comments to 2209 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Marshall, Simon" <Simon.Marshall <at> misys.com>
To: <emacs-pretest-bug <at> gnu.org>
Subject: 23.0.90; copyright-update might not update copyright
Date: Thu, 5 Feb 2009 16:39:59 -0000

[Message part 1 (text/plain, inline)]

First, emacs -Q and in the initial frame create 2 windows with 2 new
files containing:

//Copyright (c) 2008 Foo
//

Now do C-x 5 2 and in the new frame do Tools | Compile RET (it doesn't
matter if there's no Makefile etc) and in the *compilation* window in
the new frame do C-x 1 M-: (add-hook 'write-file-hooks
'copyright-update) RET.

Now in the original frame, add the word "Bar" to the end of the 2nd line
in each file, leaving point at the end of the 2nd line, and leaving the
files modified.

Now in the *compilation* window in the new frame do g ! SPC SPC to
recompile/save/update the copyright notices.  

I find that one file contains the correct:

//Copyright (c) 2008, 2009 Foo
//Bar

But the other contains the erroneous:

//Copyright (c) 2008 Foo
//Bar, 2009

With point on the comma in the 2nd line.

In GNU Emacs 23.0.90.1 (sparc-sun-solaris2.8, Motif Version 2.1.0)
 of 2009-02-03 on risksun2
Windowing system distributor `Hummingbird Ltd.', version 11.0.100015
configured using `configure
'--x-includes=/usr/openwin/include:/usr/dt/include:/usr/local/include:/u
sr/local/X11/include'
'--x-libraries=/usr/openwin/lib:/usr/dt/lib:/usr/local/lib:/usr/local/X1
1/lib' '--with-x-toolkit=motif' '--with-jpeg=no' '--with-gif=no'
'--with-tiff=no''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t




"Misys" is the trade name for Misys plc (registered in England and Wales). Registration Number: 01360027. Registered office: One Kingdom Street, London W2 6BL, United Kingdom. For a list of Misys group operating companies please go to http://www.misys.com/corp/About_Us/misys_operating_companies.html. This email and any attachments have been scanned for known viruses using multiple scanners. This email message is intended for the named recipient only. It may be privileged and/or confidential. If you are not the named recipient of this email please notify us immediately and do not copy it or use it for any purpose, nor disclose its contents to any other person. This email does not constitute the commencement of legal relations between you and Misys plc. Please refer to the executed contract between you and the relevant member of the Misys group for the identity of the contracting party with which you are dealing. 

[Message part 2 (text/html, inline)]

Message #10 received at 2209 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Daniel Pfeiffer <occitan <at> esperanto.org>
Cc: "Marshall\, Simon" <Simon.Marshall <at> misys.com>,
        2209 <at> debbugs.gnu.org
Subject: Re: 23.0.90; copyright-update might not update copyright
Date: Sat, 07 Feb 2009 12:53:27 -0500

Hi Daniel,

Could you take a look at this bug report for copyright.el?  Thanks.


"Marshall, Simon" <Simon.Marshall <at> misys.com> wrote:

> First, emacs -Q and in the initial frame create 2 windows with 2 new
> files containing:
>
> //Copyright (c) 2008 Foo
> //
>
> Now do C-x 5 2 and in the new frame do Tools | Compile RET (it doesn't
> matter if there's no Makefile etc) and in the *compilation* window in
> the new frame do C-x 1 M-: (add-hook 'write-file-hooks
> 'copyright-update) RET.
>
> Now in the original frame, add the word "Bar" to the end of the 2nd line
> in each file, leaving point at the end of the 2nd line, and leaving the
> files modified.
>
> Now in the *compilation* window in the new frame do g ! SPC SPC to
> recompile/save/update the copyright notices.  
>
> I find that one file contains the correct:
>
> //Copyright (c) 2008, 2009 Foo
> //Bar
>
> But the other contains the erroneous:
>
> //Copyright (c) 2008 Foo
> //Bar, 2009
>
> With point on the comma in the 2nd line.

Message #13 received at 2209 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 2209 <at> debbugs.gnu.org, Daniel Pfeiffer <occitan <at> esperanto.org>,
        "Marshall, Simon" <Simon.Marshall <at> misys.com>
Subject: Re: bug#2209: 23.0.90; copyright-update might not update copyright
Date: Sat, 07 Feb 2009 17:31:20 -0500

Chong Yidong wrote:

> Could you take a look at this bug report for copyright.el?  Thanks.

FWIW, I found this goes away if one sets copyright-query nil, or wraps
the y-or-n-p query in copyright-update-year in a save-excursion.

>> First, emacs -Q and in the initial frame create 2 windows with 2 new
>> files containing:
>>
>> //Copyright (c) 2008 Foo
>> //
>>
>> Now do C-x 5 2 and in the new frame do Tools | Compile RET (it doesn't
>> matter if there's no Makefile etc) and in the *compilation* window in
>> the new frame do C-x 1 M-: (add-hook 'write-file-hooks
>> 'copyright-update) RET.
>>
>> Now in the original frame, add the word "Bar" to the end of the 2nd line
>> in each file, leaving point at the end of the 2nd line, and leaving the
>> files modified.
>>
>> Now in the *compilation* window in the new frame do g ! SPC SPC to
>> recompile/save/update the copyright notices.  
>>
>> I find that one file contains the correct:
>>
>> //Copyright (c) 2008, 2009 Foo
>> //Bar
>>
>> But the other contains the erroneous:
>>
>> //Copyright (c) 2008 Foo
>> //Bar, 2009
>>
>> With point on the comma in the 2nd line.

Message #18 received at 2209-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 2209-done <at> debbugs.gnu.org
Subject: Re: bug#2209: 23.0.90; copyright-update might not update copyright
Date: Mon, 16 Feb 2009 22:00:35 -0500

Glenn Morris wrote:

> FWIW, I found this goes away if one sets copyright-query nil, or wraps
> the y-or-n-p query in copyright-update-year in a save-excursion.

Installed, in the absence of comments.

Message #21 received at 2209 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Richard Stallman <rms <at> gnu.org>
Cc: 2209 <at> debbugs.gnu.org
Subject: Re: Don't let y-or-n-p move point.
Date: Wed, 18 Feb 2009 13:04:49 -0500

Richard Stallman wrote (on Wed, 18 Feb 2009 at 07:09 -0500):

> That change makes me worry that it is papering over the real bug.

Indeed.

> How does it happen that y-or-n-p moves point?  Whatever it is, it
> could cause trouble elsewhere too.  Maybe the right fix is to make
> sure it does not happen.

The details are in the first message of bug 2209.

In theory, you should be able to retrieve it by sending a message to
request <at> debbugs.gnu.org, with "send 2209" in the body.

Message #26 received at 2209 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Richard M Stallman <rms <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 2209 <at> debbugs.gnu.org
Subject: Re: Don't let y-or-n-p move point.
Date: Wed, 18 Feb 2009 18:05:57 -0500

    > How does it happen that y-or-n-p moves point?  Whatever it is, it
    > could cause trouble elsewhere too.  Maybe the right fix is to make
    > sure it does not happen.

    The details are in the first message of bug 2209.

Maybe there is a misunderstanding.  I think you mean the message
below, but it does not say why y-or-n-p moves point.  I think it
will take investigation to figure that out.

Date: Thu, 5 Feb 2009 16:39:59 -0000
Message-ID: <63C2A154B1708946B60726AFDBA00AC00388E04D <at> ukmailemea01.misys.global.ad>
To: <emacs-pretest-bug <at> gnu.org>
Resent-Date: Thu, 05 Feb 2009 12:03:36 -0500
Cc: 
Subject: bug#2209: 23.0.90; copyright-update might not update copyright
Reply-To: "Marshall, Simon" <Simon.Marshall <at> misys.com>,
	2209 <at> debbugs.gnu.org

This is a multi-part message in MIME format.

------_=_NextPart_001_01C987B0.62F9A32A
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

First, emacs -Q and in the initial frame create 2 windows with 2 new
files containing:

//Copyright (c) 2008 Foo
//

Now do C-x 5 2 and in the new frame do Tools | Compile RET (it doesn't
matter if there's no Makefile etc) and in the *compilation* window in
the new frame do C-x 1 M-: (add-hook 'write-file-hooks
'copyright-update) RET.

Now in the original frame, add the word "Bar" to the end of the 2nd line
in each file, leaving point at the end of the 2nd line, and leaving the
files modified.

Now in the *compilation* window in the new frame do g ! SPC SPC to
recompile/save/update the copyright notices.=20=20

I find that one file contains the correct:

//Copyright (c) 2008, 2009 Foo
//Bar

But the other contains the erroneous:

//Copyright (c) 2008 Foo
//Bar, 2009

With point on the comma in the 2nd line.

Message #29 received at 2209 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: rms <at> gnu.org
Cc: 2209 <at> debbugs.gnu.org
Subject: Re: Don't let y-or-n-p move point.
Date: Wed, 18 Feb 2009 19:52:29 -0500

Richard M Stallman wrote:

> Maybe there is a misunderstanding.  I think you mean the message
> below, but it does not say why y-or-n-p moves point.  I think it
> will take investigation to figure that out.

Yes. This example can be used as a test case.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.