GNU bug report logs - #21799
Requesting review for change to js.el

Previous Next

Full log

Message #8 received at 21799 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>, 21799 <at> debbugs.gnu.org
Subject: Re: bug#21799: Requesting review for change to js.el
Date: Sat, 31 Oct 2015 14:36:04 +0200

On 10/31/2015 11:37 AM, Jackson Hamilton wrote:
> See attached patch. Adds JSX indentation support to js-mode.

Hi Jackson,

JSX files have a different extension, right? Why don't we make it a 
separate major mode?

It can also live in js.el and derive from js-mode. The only thing it'll 
change (for now?) is the indentation function.

And for those who also want the js2-mode AST, we can either tell them to 
use js2-minor-mode, or also create a js2-jsx-mode that would derive from 
js2-mode and use the indentation function defined here.

Then there will be no need for the option js-indent-jsx.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.