GNU bug report logs - #21799
Requesting review for change to js.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21799 in the body.
You can then email your comments to 21799 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: Requesting review for change to js.el
Date: Sat, 31 Oct 2015 02:37:33 -0700

[Message part 1 (text/plain, inline)]

See attached patch. Adds JSX indentation support to js-mode.

[Message part 2 (text/html, inline)]

[jsx.patch (text/x-patch, attachment)]

Message #8 received at 21799 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>, 21799 <at> debbugs.gnu.org
Subject: Re: bug#21799: Requesting review for change to js.el
Date: Sat, 31 Oct 2015 14:36:04 +0200

On 10/31/2015 11:37 AM, Jackson Hamilton wrote:
> See attached patch. Adds JSX indentation support to js-mode.

Hi Jackson,

JSX files have a different extension, right? Why don't we make it a 
separate major mode?

It can also live in js.el and derive from js-mode. The only thing it'll 
change (for now?) is the indentation function.

And for those who also want the js2-mode AST, we can either tell them to 
use js2-minor-mode, or also create a js2-jsx-mode that would derive from 
js2-mode and use the indentation function defined here.

Then there will be no need for the option js-indent-jsx.

Message #11 received at 21799 <at> debbugs.gnu.org (full text, mbox):

From: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 21799 <at> debbugs.gnu.org
Subject: Re: bug#21799: Requesting review for change to js.el
Date: Sat, 31 Oct 2015 09:53:05 -0700

[Message part 1 (text/plain, inline)]

Some use the ".jsx" extension, some just use ".js". One could also do
(add-to-list 'auto-mode-alist '("\\.js\\'" . js-jsx-mode)).

I like the idea of separating the modes as js-jsx-mode and js2-jsx-mode,
I'll make that change.

On Sat, Oct 31, 2015 at 5:36 AM, Dmitry Gutov <dgutov <at> yandex.ru> wrote:

> On 10/31/2015 11:37 AM, Jackson Hamilton wrote:
>
>> See attached patch. Adds JSX indentation support to js-mode.
>>
>
> Hi Jackson,
>
> JSX files have a different extension, right? Why don't we make it a
> separate major mode?
>
> It can also live in js.el and derive from js-mode. The only thing it'll
> change (for now?) is the indentation function.
>
> And for those who also want the js2-mode AST, we can either tell them to
> use js2-minor-mode, or also create a js2-jsx-mode that would derive from
> js2-mode and use the indentation function defined here.
>
> Then there will be no need for the option js-indent-jsx.
>

[Message part 2 (text/html, inline)]

Message #14 received at 21799 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>
Cc: 21799 <at> debbugs.gnu.org
Subject: Re: bug#21799: Requesting review for change to js.el
Date: Sat, 31 Oct 2015 19:05:42 +0200

On 10/31/2015 06:53 PM, Jackson Hamilton wrote:
> Some use the ".jsx" extension, some just use ".js". One could also do
> (add-to-list 'auto-mode-alist '("\\.js\\'" . js-jsx-mode)).

That's a good point.

> I like the idea of separating the modes as js-jsx-mode and js2-jsx-mode,
> I'll make that change.

Thanks.

Message #17 received at 21799 <at> debbugs.gnu.org (full text, mbox):

From: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 21799 <at> debbugs.gnu.org
Subject: Re: bug#21799: Requesting review for change to js.el
Date: Sat, 31 Oct 2015 10:53:07 -0700

[Message part 1 (text/plain, inline)]

Updated with the addition of js-jsx-mode (attached).

Also, has the ChangeLog maintenance process changed? I don't see a
"current" ChangeLog to which I may add entries.

On Sat, Oct 31, 2015 at 10:05 AM, Dmitry Gutov <dgutov <at> yandex.ru> wrote:

> On 10/31/2015 06:53 PM, Jackson Hamilton wrote:
>
>> Some use the ".jsx" extension, some just use ".js". One could also do
>> (add-to-list 'auto-mode-alist '("\\.js\\'" . js-jsx-mode)).
>>
>
> That's a good point.
>
> I like the idea of separating the modes as js-jsx-mode and js2-jsx-mode,
>> I'll make that change.
>>
>
> Thanks.
>

[Message part 2 (text/html, inline)]

[jsx.patch (text/x-patch, attachment)]

Message #20 received at 21799 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>
Cc: 21799 <at> debbugs.gnu.org
Subject: Re: bug#21799: Requesting review for change to js.el
Date: Sat, 31 Oct 2015 21:20:40 +0200

On 10/31/2015 07:53 PM, Jackson Hamilton wrote:

> Also, has the ChangeLog maintenance process changed? I don't see a
> "current" ChangeLog to which I may add entries.

Now we put ChangeLog entries into the commit messages.

See CONTRIBUTE, "Generating ChangeLog entries", second part.

Message #23 received at 21799 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>
Cc: 21799 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#21799: Requesting review for change to js.el
Date: Tue, 23 Feb 2016 16:15:11 +1100

Jackson Hamilton <jackson <at> jacksonrayhamilton.com> writes:

> Updated with the addition of js-jsx-mode (attached).

Looks good to me, I think, but I think it should probably be separated
out into its own file: jsx-mode.el.

Also, I can't find your name in the Emacs copyright assignment file.
Would you be willing to sign FSF copyright assignment papers?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #28 received at 21799-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Lars Ingebrigtsen <larsi <at> gnus.org>,
 Jackson Hamilton <jackson <at> jacksonrayhamilton.com>
Cc: 21799-done <at> debbugs.gnu.org
Subject: Re: bug#21799: Requesting review for change to js.el
Date: Tue, 23 Feb 2016 12:14:35 +0200

On 02/23/2016 07:15 AM, Lars Ingebrigtsen wrote:

> Looks good to me, I think, but I think it should probably be separated
> out into its own file: jsx-mode.el.

Sorry, we've already applied it and forgot to close the bug.

Calling it jsx-mode.el might be suboptimal due to the conflict: 
https://github.com/jsx/jsx-mode.el (and that one's for a different JSX).

> Also, I can't find your name in the Emacs copyright assignment file.

It's there, as "Jackson Ray Hamilton".

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.