GNU bug report logs - #21799
Requesting review for change to js.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#21799: closed (Requesting review for change to js.el)
Date: Tue, 23 Feb 2016 10:15:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 23 Feb 2016 12:14:35 +0200
with message-id <56CC310B.2020200 <at> yandex.ru>
and subject line Re: bug#21799: Requesting review for change to js.el
has caused the debbugs.gnu.org bug report #21799,
regarding Requesting review for change to js.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
21799: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21799
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: Requesting review for change to js.el
Date: Sat, 31 Oct 2015 02:37:33 -0700

[Message part 3 (text/plain, inline)]

See attached patch. Adds JSX indentation support to js-mode.

[Message part 4 (text/html, inline)]

[jsx.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Lars Ingebrigtsen <larsi <at> gnus.org>,
 Jackson Hamilton <jackson <at> jacksonrayhamilton.com>
Cc: 21799-done <at> debbugs.gnu.org
Subject: Re: bug#21799: Requesting review for change to js.el
Date: Tue, 23 Feb 2016 12:14:35 +0200

On 02/23/2016 07:15 AM, Lars Ingebrigtsen wrote:

> Looks good to me, I think, but I think it should probably be separated
> out into its own file: jsx-mode.el.

Sorry, we've already applied it and forgot to close the bug.

Calling it jsx-mode.el might be suboptimal due to the conflict: 
https://github.com/jsx/jsx-mode.el (and that one's for a different JSX).

> Also, I can't find your name in the Emacs copyright assignment file.

It's there, as "Jackson Ray Hamilton".

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.