GNU bug report logs - #21783
25.0.50; python.el does not support new Python 3.5 keywords

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21783 in the body.
You can then email your comments to 21783 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lele Gaifax <lele <at> metapensiero.it>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; python.el does not support new Python 3.5 keywords
Date: Thu, 29 Oct 2015 10:00:04 +0100

[Message part 1 (text/plain, inline)]

Python 3.5, released in mid September 2015, introduced a few new keywords
to better support asynchronous code, "async" and "await" in particular. See
https://www.python.org/dev/peps/pep-0492/ for details.

To avoid breaking already written users code, they are technically not
"reserved keywords", but accordingly to the plan they will become that in
Python 3.7 (https://www.python.org/dev/peps/pep-0492/#id75).

Currently python.el doesn't know anything about them, so it obviously cannot
properly indent the following code:

  async def coroutine(foo, bar):
  |

where "|" represent the cursor position, nor highlight them in any way.

I'm attaching a patch that implements such support, with some test cases. See
also the thread http://thread.gmane.org/gmane.emacs.devel/190950 where I
initially sent the same patch and where I've been solicited to create a bug
report.

Hope this helps,

thanks in advance,
ciao, lele.

[python_el+pep492.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele <at> metapensiero.it  |                 -- Fortunato Depero, 1929.

Message #8 received at 21783 <at> debbugs.gnu.org (full text, mbox):

From: Lele Gaifax <lele <at> metapensiero.it>
To: 21783 <at> debbugs.gnu.org
Subject: Copyright assignment
Date: Fri, 18 Dec 2015 11:29:51 +0100

Maybe I could have stated that I fulfilled the assignment process (# 988143),
should that smooth the acceptance of the patch.
-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele <at> metapensiero.it  |                 -- Fortunato Depero, 1929.

Message #11 received at 21783 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lele Gaifax <lele <at> metapensiero.it>,
 Fabián Ezequiel Gallina <fgallina <at> gnu.org>
Cc: 21783 <at> debbugs.gnu.org
Subject: Re: bug#21783: Copyright assignment
Date: Fri, 18 Dec 2015 12:55:03 +0200

> From: Lele Gaifax <lele <at> metapensiero.it>
> Date: Fri, 18 Dec 2015 11:29:51 +0100
> 
> Maybe I could have stated that I fulfilled the assignment process (# 988143),
> should that smooth the acceptance of the patch.

Thanks.  This patch should be reviewed and approved first.  Fabián,
can you look into this patch, please?

Message #14 received at 21783 <at> debbugs.gnu.org (full text, mbox):

From: Lele Gaifax <lele <at> metapensiero.it>
To: 21783 <at> debbugs.gnu.org
Subject: Re: bug#21783: Copyright assignment
Date: Mon, 01 Feb 2016 09:44:47 +0100

Is there anything else I could do to help getting this into Emacs 25?

thank you&ciao, lele.
-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele <at> metapensiero.it  |                 -- Fortunato Depero, 1929.

Message #17 received at 21783 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Lele Gaifax <lele <at> metapensiero.it>
Cc: Fabián Ezequiel Gallina <fgallina <at> gnu.org>,
 Mark Oteiza <mvoteiza <at> udel.edu>, 21783 <at> debbugs.gnu.org
Subject: Re: bug#21783: Copyright assignment
Date: Tue, 23 Feb 2016 16:18:06 +1100

Lele Gaifax <lele <at> metapensiero.it> writes:

> Is there anything else I could do to help getting this into Emacs 25?

I think we're basically waiting for somebody with Python mode experience
to review the patch.  Fabián?  Mark?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #22 received at 21783-close <at> debbugs.gnu.org (full text, mbox):

From: Jorgen Schäfer <jorgen.schaefer <at> gmail.com>
To: 21783-close <at> debbugs.gnu.org
Subject: Patch applied
Date: Wed, 06 Apr 2016 08:59:20 +0000

[Message part 1 (text/plain, inline)]

Hello!
I just pushed this patch to git master as 1f6b0bc1. Thank you so much for
your contribution and I am very sorry that it took so long to get into the
repository.

Regards,
Jorgen

[Message part 2 (text/html, inline)]

Message #25 received at 21783 <at> debbugs.gnu.org (full text, mbox):

From: Lele Gaifax <lele <at> metapensiero.it>
To: 21783 <at> debbugs.gnu.org
Subject: Re: bug#21783: closed (Patch applied)
Date: Wed, 06 Apr 2016 12:52:30 +0200

GNU bug Tracking System <help-debbugs <at> gnu.org> writes:

> I just pushed this patch to git master as 1f6b0bc1. Thank you so much for
> your contribution and I am very sorry that it took so long to get into the
> repository.

Thank you Jorgen, no need to apologize, really!

But I wonder: is there any chance to get this "backported" to the emacs-25
branch as well? Is there anything I should do to make that happen?

thanks again,
ciao, lele.
-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele <at> metapensiero.it  |                 -- Fortunato Depero, 1929.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.