GNU bug report logs - #21766
25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace

Previous Next

Full log

Message #53 received at 21766 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Leake <stephen_leake <at> stephe-leake.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Andreas Schwab <schwab <at> suse.de>, Emacs developers <emacs-devel <at> gnu.org>,
 Markus Triska <triska <at> metalevel.at>, 21766 <at> debbugs.gnu.org
Subject: Re: bug#21766: 25.0.50;
 delete-trailing-whitespace sometimes deletes non-whitespace
Date: Tue, 27 Oct 2015 20:51:42 -0500

Juanma Barranquero <lekktu <at> gmail.com> writes:

> This will be my first ERT test, so, does the following (attached, because
> Gmail) patch look acceptable?

Looks good to me, except see below.

> And, it is possible to commit a file with trailing whitespace?

Yes, but it's also very easy to lose it, thus breaking the test. I
suggest instead to save the file without extra whitespace, and add code
to the test to insert the extra whitespace. That way you can also add
comments about why this test exists, etc.

-- 
-- Stephe

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.