GNU bug report logs - #21766
25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace

Previous Next

Package: emacs;

Reported by: Markus Triska <triska <at> metalevel.at>

Date: Mon, 26 Oct 2015 23:10:01 UTC

Severity: normal

Merged with 21769

Found in version 25.0.50

Done: Juanma Barranquero <lekktu <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #14 received at 21766 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
Cc: 21766 <at> debbugs.gnu.org
Subject: Re: bug#21766: 25.0.50;
 delete-trailing-whitespace sometimes deletes non-whitespace
Date: Tue, 27 Oct 2015 08:53:28 +0100

[Message part 1 (text/plain, inline)]
On Tue, Oct 27, 2015 at 8:07 AM, Andreas Röhler <
andreas.roehler <at> easy-emacs.de> wrote:

> First fix looks cleaner.

Shorter, indeed, though it does more work, and inside a loop. I really have
no preference.

> Such a basic routine should preserve matches by its own virtue.

Are you talking about delete-trailing-whitespace or skip-syntax-backward?

Anyway, I've always thought that functions should preserve the match data,
but I was told that doing so is a (relatively) expensive operation, and
functions that use match data should be the ones to make sure that it is
valid when they need it.

    J

[Message part 2 (text/html, inline)]
This bug report was last modified 9 years and 210 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.