GNU bug report logs - #21744
24.5; diff-mode highlight only suitable part

Previous Next

Package: emacs;

Reported by: Evgeniy Dushistov <dushistov <at> mail.ru>

Date: Fri, 23 Oct 2015 14:57:01 UTC

Severity: wishlist

Tags: fixed

Merged with 12747, 16798, 18128

Found in versions 23.4, 24.5

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Evgeniy Dushistov <dushistov <at> mail.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5; diff-mode highlight only suitable part
Date: Fri, 23 Oct 2015 17:55:47 +0300
For example let's I have such content of *vc-diff*

diff --git a/cmake/FindLibClang.cmake b/cmake/FindLibClang.cmake
index 8aa7689..62b5b08 100644
--- a/cmake/FindLibClang.cmake
+++ b/cmake/FindLibClang.cmake
@@ -72,7 +72,7 @@ if (NOT LIBCLANG_CXXFLAGS)
     endif ()
     set(LIBCLANG_CXXFLAGS "-I${LIBCLANG_CXXFLAGS}")
   endif ()
-  string(REGEX REPLACE "-([Og][0-9]*|std=c\\+\\+..|(W|f)[a-zA-Z-]*|DNDEBUG) ?" "" LIBCLANG_CXXFLAGS "${LIBCLANG_CXXFLAGS}")
+  string(REGEX REPLACE "-([Og][0-9]*|std=c\\+\\+..|(W|f)[=a-zA-Z-]*|DNDEBUG) ?" "" LIBCLANG_CXXFLAGS "${LIBCLANG_CXXFLAGS}")
   set(LIBCLANG_CXXFLAGS ${LIBCLANG_CXXFLAGS} CACHE STRING "The LLVM C++ compiler flags needed to compile LLVM based applications.")
   unset(LIBCLANG_CXXFLAGS_HACK_CMAKECACHE_DOT_TEXT_BULLSHIT CACHE)
 endif ()

the diff-mode highlight string with starting "-" with red, and starting "+" with green,
it would be great if it  highlight also difference between strings.
There is only "=" symbol difference between two lines above, so it would be great
if emacs highlight also "=" in the second string.

You can see how github doing this:
https://github.com/Dushistov/rtags/commit/5d0419c453dde58bf3a37a00bf0e63bd186154bc

-- 
/Evgeniy




This bug report was last modified 7 years and 7 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.