GNU bug report logs - #21744
24.5; diff-mode highlight only suitable part

Previous Next

Package: emacs;

Reported by: Evgeniy Dushistov <dushistov <at> mail.ru>

Date: Fri, 23 Oct 2015 14:57:01 UTC

Severity: wishlist

Tags: fixed

Merged with 12747, 16798, 18128

Found in versions 23.4, 24.5

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21744 in the body.
You can then email your comments to 21744 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#21744; Package emacs. (Fri, 23 Oct 2015 14:57:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Evgeniy Dushistov <dushistov <at> mail.ru>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 23 Oct 2015 14:57:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Evgeniy Dushistov <dushistov <at> mail.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5; diff-mode highlight only suitable part
Date: Fri, 23 Oct 2015 17:55:47 +0300
For example let's I have such content of *vc-diff*

diff --git a/cmake/FindLibClang.cmake b/cmake/FindLibClang.cmake
index 8aa7689..62b5b08 100644
--- a/cmake/FindLibClang.cmake
+++ b/cmake/FindLibClang.cmake
@@ -72,7 +72,7 @@ if (NOT LIBCLANG_CXXFLAGS)
     endif ()
     set(LIBCLANG_CXXFLAGS "-I${LIBCLANG_CXXFLAGS}")
   endif ()
-  string(REGEX REPLACE "-([Og][0-9]*|std=c\\+\\+..|(W|f)[a-zA-Z-]*|DNDEBUG) ?" "" LIBCLANG_CXXFLAGS "${LIBCLANG_CXXFLAGS}")
+  string(REGEX REPLACE "-([Og][0-9]*|std=c\\+\\+..|(W|f)[=a-zA-Z-]*|DNDEBUG) ?" "" LIBCLANG_CXXFLAGS "${LIBCLANG_CXXFLAGS}")
   set(LIBCLANG_CXXFLAGS ${LIBCLANG_CXXFLAGS} CACHE STRING "The LLVM C++ compiler flags needed to compile LLVM based applications.")
   unset(LIBCLANG_CXXFLAGS_HACK_CMAKECACHE_DOT_TEXT_BULLSHIT CACHE)
 endif ()

the diff-mode highlight string with starting "-" with red, and starting "+" with green,
it would be great if it  highlight also difference between strings.
There is only "=" symbol difference between two lines above, so it would be great
if emacs highlight also "=" in the second string.

You can see how github doing this:
https://github.com/Dushistov/rtags/commit/5d0419c453dde58bf3a37a00bf0e63bd186154bc

-- 
/Evgeniy




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#21744; Package emacs. (Fri, 23 Oct 2015 15:45:02 GMT) Full text and rfc822 format available.

Message #8 received at 21744 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Evgeniy Dushistov <dushistov <at> mail.ru>, 21744 <at> debbugs.gnu.org
Subject: Re: bug#21744: 24.5; diff-mode highlight only suitable part
Date: Fri, 23 Oct 2015 18:44:14 +0300
Hi Evgeniy,

On 10/23/2015 05:55 PM, Evgeniy Dushistov wrote:
> the diff-mode highlight string with starting "-" with red, and starting "+" with green,
> it would be great if it  highlight also difference between strings.
> There is only "=" symbol difference between two lines above, so it would be great
> if emacs highlight also "=" in the second string.

We currently have this feature in the shape of diff-auto-refine-mode. 
Try pressing `n' or `p': the navigation commands also refine the hunks 
to show the differences.

There has been some talk of doing that automatically (using font-lock), 
but the refining algorithm is rather slow on large hunks.

I'd also recommend installing diff-hl (available in ELPA): it remaps the 
vc-diff command to its own wrapper that also scrolls to the hunk 
corresponding to the current line, and refines it.




Merged 12747 16798 18128 21744. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 12 Jul 2018 00:29:02 GMT) Full text and rfc822 format available.

Added tag(s) fixed. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 12 Jul 2018 00:29:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 27.1, send any further explanations to 12747 <at> debbugs.gnu.org and Oleksandr Gavenko <gavenkoa <at> gmail.com> Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 12 Jul 2018 00:29:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 10 Aug 2018 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 7 years and 5 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.