GNU bug report logs - #21722
25.0.50; Unexpected point position after undo

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21722 in the body.
You can then email your comments to 21722 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Markus Triska <triska <at> metalevel.at>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; Unexpected point position after undo
Date: Wed, 21 Oct 2015 01:14:07 +0200

In "emacs -Q", when I insert into *scratch* the form:

   (progn (end-of-line) (insert "\nhi"))

then place point on the "g" and press C-M-x C-/, then the insertion is
undone, and point remains on the "g", as expected. When I then press:

   C-h f C-g C-M-x C-/

the insertion is undone, and point is unexpectedly placed at the end of
the form instead of remaining on the "g". When I then place point on the
"g" again, and again press C-M-x C-/, point again stays on the "g".

Thus, point position after undo is sometimes unexpected.

For comparison: In Emacs 22.2, point remains on the "g" in all these
cases. This is more consistent, and, in my view, therefore preferable.


In GNU Emacs 25.0.50.5 (x86_64-apple-darwin14.1.0, X toolkit, Xaw3d scroll bars)
 of 2015-10-04
Repository revision: acfb5cd0353406784f085ddb6edfb0d0587048c8
Windowing system distributor 'The X.Org Foundation', version 11.0.11502000
Configured using:
 'configure --without-ns CFLAGS=-I/opt/local/include
 LDFLAGS=-L/opt/local/lib'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG IMAGEMAGICK GSETTINGS NOTIFY ACL GNUTLS
LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Message #8 received at 21722 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Markus Triska <triska <at> metalevel.at>
Cc: 21722 <at> debbugs.gnu.org
Subject: Re: 25.0.50; Unexpected point position after undo
Date: Sun, 03 Jul 2016 18:19:52 +0300

I think the reason for this problem is in keyboard.c.  C-g causes us
to throw to top-level right after reading the key, and the
undo-related variables are set up in the command loop after that.  I
guess something in this sequence interferes with recording of point
position.

Message #15 received at 21722 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Markus Triska <triska <at> metalevel.at>
Cc: 21722 <at> debbugs.gnu.org, 1095 <at> debbugs.gnu.org
Subject: Re: bug#21722: 25.0.50; Unexpected point position after undo
Date: Wed, 10 Aug 2016 21:16:56 -0400

Markus Triska <triska <at> metalevel.at> writes:

> In "emacs -Q", when I insert into *scratch* the form:
>
>    (progn (end-of-line) (insert "\nhi"))
>
> then place point on the "g" and press C-M-x C-/, then the insertion is
> undone, and point remains on the "g", as expected. When I then press:
>
>    C-h f C-g C-M-x C-/
>
> the insertion is undone, and point is unexpectedly placed at the end of
> the form instead of remaining on the "g". When I then place point on the
> "g" again, and again press C-M-x C-/, point again stays on the "g".
>
> Thus, point position after undo is sometimes unexpected.

In 25.1-rc1 the point position stays in place for both cases.  So I
guess this can be considered fixed?

(In 25.0.93 (which I happened to have lying around), it moves in both
cases)

Message #18 received at 21722 <at> debbugs.gnu.org (full text, mbox):

From: Markus Triska <triska <at> metalevel.at>
To: npostavs <at> users.sourceforge.net
Cc: 21722 <at> debbugs.gnu.org, 1095 <at> debbugs.gnu.org
Subject: Re: bug#21722: 25.0.50; Unexpected point position after undo
Date: Fri, 12 Aug 2016 08:37:49 +0200

npostavs <at> users.sourceforge.net writes:

> In 25.1-rc1 the point position stays in place for both cases.  So I
> guess this can be considered fixed?

Yes, this is fixed. Phillip Lord corrected this in #23871, thank you!

All the best,
Markus

Message #25 received at 21722 <at> debbugs.gnu.org (full text, mbox):

From: phillip.lord <at> russet.org.uk (Phillip Lord)
To: npostavs <at> users.sourceforge.net
Cc: 21722 <at> debbugs.gnu.org, 1095 <at> debbugs.gnu.org,
 Markus Triska <triska <at> metalevel.at>
Subject: Re: bug#21722: 25.0.50; Unexpected point position after undo
Date: Fri, 19 Aug 2016 16:45:50 +0100

npostavs <at> users.sourceforge.net writes:

> Markus Triska <triska <at> metalevel.at> writes:
>
>> In "emacs -Q", when I insert into *scratch* the form:
>>
>>    (progn (end-of-line) (insert "\nhi"))
>>
>> then place point on the "g" and press C-M-x C-/, then the insertion is
>> undone, and point remains on the "g", as expected. When I then press:
>>
>>    C-h f C-g C-M-x C-/
>>
>> the insertion is undone, and point is unexpectedly placed at the end of
>> the form instead of remaining on the "g". When I then place point on the
>> "g" again, and again press C-M-x C-/, point again stays on the "g".
>>
>> Thus, point position after undo is sometimes unexpected.
>
> In 25.1-rc1 the point position stays in place for both cases.  So I
> guess this can be considered fixed?
>
> (In 25.0.93 (which I happened to have lying around), it moves in both
> cases)


Sorry, think I just forgot to close this one. Thanks for checking.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.