GNU bug report logs - #21688
25.0.50; abort in regex.c during "align"

Previous Next

Package: emacs;

Reported by: Ken Raeburn <raeburn <at> permabit.com>

Date: Thu, 15 Oct 2015 08:26:01 UTC

Severity: normal

Merged with 21802

Found in version 25.0.50

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: John Wiegley <johnw <at> newartisans.com>, 21688 <at> debbugs.gnu.org, Ken Brown <kbrown <at> cornell.edu>
Subject: bug#21688: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort
Date: Sat, 21 Nov 2015 21:23:31 -0500

> Perhaps Stefan or someone else will be able to knock a few cycles free to
> fix this. I'm afraid I've been spending most of my time elsewhere in Emacs
> recently, what with the new module code and all.

My crystal ball tells me that maybe it's just the following hunk which
is to blame:

   diff --git a/src/syntax.c b/src/syntax.c
   index 5b0ec6d..f939a76 100644
   --- a/src/syntax.c
   +++ b/src/syntax.c
   @@ -514,7 +514,6 @@ update_syntax_table_forward (ptrdiff_t charpos, bool init,
        {
          eassert (NILP (object));
          eassert (charpos >= gl_state.e_property);
   -      parse_sexp_propertize (charpos);
        }
      else
        {

I think this hunk is just a mistake that was introduced during the
"back&forth" that took place when you added and then removed the "bool
propertize" argument.


        Stefan
This bug report was last modified 9 years and 240 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.