GNU bug report logs - #21681
[PATCH] Fix formatting of lexical-binding at eof warning

Previous Next

Package: emacs;

Reported by: Noam Postavsky <npostavs <at> gmail.com>

Date: Tue, 13 Oct 2015 22:54:02 UTC

Severity: wishlist

Tags: patch

Merged with 17518, 21307

Found in versions 24.4.50, 25.0.50

Fixed in version 25.0.91

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 21681 <at> debbugs.gnu.org
Subject: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning
Date: Wed, 14 Oct 2015 20:42:25 +0300
> Date: Wed, 14 Oct 2015 12:56:28 -0400
> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
> Cc: 21681 <at> debbugs.gnu.org
> 
> On Wed, Oct 14, 2015 at 12:28 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > Why 'files', and not something more concrete, like
> > 'file-local-variables'?
> 
> The docstring for display-warning says the TYPE arg should be a custom group.
> 
> display-warning doesn't actually enforce this, and it looks like the
> choice of symbol(s) is only relevant to warning-suppress-log-types.
> Perhaps the TYPE should be '(files local-variables) so the user can
> suppress it along with all files warnings or just suppress it on it's
> own, but display-warning only prints the 1st symbol of the list so the
> warning text itself wouldn't change.

I find "files" no more explanatory that "warning".  If we lack
infrastructure to display meaningful messages that unequivocally point
to the nature of the problem, let's add the missing infrastructure.

Thanks.




This bug report was last modified 9 years and 109 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.