GNU bug report logs - #21025
tabulated-list.el: It should preserve header line set by derived modes. (Encl. a suggested PATCH)

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: Vaidheeswaran C <vaidheeswaran.chinnaraju <at> gmail.com>, 21025 <at> debbugs.gnu.org
Subject: bug#21025: tabulated-list.el: It should preserve header line set by derived modes. (Encl. a suggested PATCH)
Date: Tue, 25 Jun 2019 18:39:24 +0200

Drew Adams <drew.adams <at> oracle.com> writes:

>> >> -      (overlay-put tabulated-list--header-overlay 'face 'underline))))
>> >> +      (overlay-put tabulated-list--header-overlay
>> >> +                   'face '(:overline t :underline t :weight bold)))))
>> >
>> > This might be more controversial, though.  I think it looks nice, but
>> > some people don't like so many lines.  Perhaps it should be a defface,
>> > so that people can change this themselves?  The default could be what
>> > you're describing, though.
>> 
>> I've now done this change and otherwise applied your patch.
>
> This is a bad way to do things - makes it difficult
> for users do customize the appearance.  Emacs is "the
> extensible, customizable, self-documenting, real-time
> display editor".
>
> The right way to take care of what is essentially a
> user's preference for column-header appearance is not
> to change the hard-coded appearance but to define a
> face for this in `tabulated-list.el'.  Then ALL users
> can get the appearance they want just by customizing
> that face.

That's what I did, and that's what I said I did.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.