GNU bug report logs - #21024
help-xref-button in header line doesn't work (PATCH attached)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21024 in the body.
You can then email your comments to 21024 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vaidheeswaran C <vaidheeswaran.chinnaraju <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: help-xref-button in header line doesn't work (PATCH attached)
Date: Thu, 09 Jul 2015 23:04:07 +0530

[Message part 1 (text/plain, inline)]

1. Copy this snippet to scratch buffer and eval it.

(define-button-type 'hello-world
  :supertype 'help-xref
  'help-function (lambda ()
		   (message "Hello World")))

(setq header-line-format
      (make-text-button "Hello World" nil 'type 'hello-world))

2. Click on the header buton

3. Note the following stack trace


Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p
(#("Hello World" 0 11 (button (t) category hello-world-button)) . 10))
  button-start((#("Hello World" 0 11 (button (t) category
hello-world-button)) . 10))
  help-button-action((#("Hello World" 0 11 (button (t) category
hello-world-button)) . 10))
  button-activate((#("Hello World" 0 11 (button (t) category
hello-world-button)) . 10) t)
  push-button((mouse-2 (#<window 18 on *Backtrace*> header-line (103 .
14) 11071944 (#("Hello World" 0 11 (button (t) category
hello-world-button)) . 10) nil (10 . -1) nil (3 . 14) (10 . 18))))
  funcall-interactively(push-button (mouse-2 (#<window 18 on
*Backtrace*> header-line (103 . 14) 11071944 (#("Hello World" 0 11
(button (t) category hello-world-button)) . 10) nil (10 . -1) nil (3 .
14) (10 . 18))))
  call-interactively(push-button nil nil)
  command-execute(push-button)

----------------------------------------------------------------

This bug is related to bug#12817: 24.2; The button library does not
work on the header line.  The sole difference here is that button is a
help-xref button.

See http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-12/msg00203.html

The related commit is 24fc948039

----------------------------------------------------------------

Without getting in to nitty gritties of the "area buttons", the fix is
fairly simple once you notice that `help-do-xref' doesn't use the
first argument.

See the attached patch.

----------------------------------------------------------------

(I am working on a dictionary client for Emacs.  I will circulate the
module -- I call it edictc.el -- in another week.  The package uses
xref links in header line, FWIW.)

[help-mode.diff (text/x-patch, attachment)]

Message #8 received at 21024 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Vaidheeswaran C <vaidheeswaran.chinnaraju <at> gmail.com>
Cc: 21024 <at> debbugs.gnu.org
Subject: Re: bug#21024: help-xref-button in header line doesn't work (PATCH
 attached)
Date: Tue, 23 Feb 2016 20:46:27 +1100

Vaidheeswaran C <vaidheeswaran.chinnaraju <at> gmail.com> writes:

> This bug is related to bug#12817: 24.2; The button library does not
> work on the header line.  The sole difference here is that button is a
> help-xref button.
>
> See http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-12/msg00203.html
>
> The related commit is 24fc948039

Thanks for the patch; applied to emacs-25.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.