GNU bug report logs - #20916
25.0.50; [PATCH] Calc `s p' glitch

Previous Next

Package: emacs;

Reported by: Wolfgang Jenkner <wjenkner <at> inode.at>

Date: Sun, 28 Jun 2015 14:05:03 UTC

Severity: normal

Tags: patch

Found in version 25.0.50

Fixed in version 25.1

Done: Wolfgang Jenkner <wjenkner <at> inode.at>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Wolfgang Jenkner <wjenkner <at> inode.at>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#20916: closed (25.0.50; [PATCH] Calc `s p' glitch)
Date: Mon, 29 Jun 2015 12:56:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 29 Jun 2015 14:54:32 +0200
with message-id <85oajyad3p.fsf <at> iznogoud.viz>
and subject line Re: bug#20916: 25.0.50; [PATCH] Calc `s p' glitch
has caused the debbugs.gnu.org bug report #20916,
regarding 25.0.50; [PATCH] Calc `s p' glitch
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
20916: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20916
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Wolfgang Jenkner <wjenkner <at> inode.at>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; [PATCH] Calc `s p' glitch
Date: Sun, 28 Jun 2015 15:57:57 +0200
May I push the following patch?

-- >8 --
From 4c78b6aa26675f980d37fca7c0924f5219a4edb6 Mon Sep 17 00:00:00 2001
From: Wolfgang Jenkner <wjenkner <at> inode.at>
Date: Sun, 28 Jun 2015 15:46:57 +0200
Subject: [PATCH] * lisp/calc-store.el (calc-insert-permanent-variable): Heed
 case.

Otherwise `s p' of f and F will stomp on each other's value.
---
 lisp/calc/calc-store.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/calc/calc-store.el b/lisp/calc/calc-store.el
index 11bf964..91b927a 100644
--- a/lisp/calc/calc-store.el
+++ b/lisp/calc/calc-store.el
@@ -609,7 +609,8 @@
 
 (defun calc-insert-permanent-variable (var)
   (goto-char (point-min))
-  (if (search-forward (concat "(setq " (symbol-name var) " '") nil t)
+  (if (let (case-fold-search)
+        (search-forward (concat "(setq " (symbol-name var) " '") nil t))
       (progn
 	(setq calc-pv-pos (point-marker))
 	(forward-line -1)
-- 
2.4.2



[Message part 3 (message/rfc822, inline)]
From: Wolfgang Jenkner <wjenkner <at> inode.at>
To: 20916-done <at> debbugs.gnu.org
Cc: jay.p.belanger <at> gmail.com
Subject: Re: bug#20916: 25.0.50; [PATCH] Calc `s p' glitch
Date: Mon, 29 Jun 2015 14:54:32 +0200
Version: 25.1

The Calc maintainer kindly replied in private email.

Pushed.


This bug report was last modified 10 years and 24 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.