GNU bug report logs - #20916
25.0.50; [PATCH] Calc `s p' glitch

Previous Next

Package: emacs;

Reported by: Wolfgang Jenkner <wjenkner <at> inode.at>

Date: Sun, 28 Jun 2015 14:05:03 UTC

Severity: normal

Tags: patch

Found in version 25.0.50

Fixed in version 25.1

Done: Wolfgang Jenkner <wjenkner <at> inode.at>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20916 in the body.
You can then email your comments to 20916 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to jay.p.belanger <at> gmail.com, bug-gnu-emacs <at> gnu.org:
bug#20916; Package emacs. (Sun, 28 Jun 2015 14:05:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Wolfgang Jenkner <wjenkner <at> inode.at>:
New bug report received and forwarded. Copy sent to jay.p.belanger <at> gmail.com, bug-gnu-emacs <at> gnu.org. (Sun, 28 Jun 2015 14:05:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wolfgang Jenkner <wjenkner <at> inode.at>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; [PATCH] Calc `s p' glitch
Date: Sun, 28 Jun 2015 15:57:57 +0200
May I push the following patch?

-- >8 --
From 4c78b6aa26675f980d37fca7c0924f5219a4edb6 Mon Sep 17 00:00:00 2001
From: Wolfgang Jenkner <wjenkner <at> inode.at>
Date: Sun, 28 Jun 2015 15:46:57 +0200
Subject: [PATCH] * lisp/calc-store.el (calc-insert-permanent-variable): Heed
 case.

Otherwise `s p' of f and F will stomp on each other's value.
---
 lisp/calc/calc-store.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/calc/calc-store.el b/lisp/calc/calc-store.el
index 11bf964..91b927a 100644
--- a/lisp/calc/calc-store.el
+++ b/lisp/calc/calc-store.el
@@ -609,7 +609,8 @@
 
 (defun calc-insert-permanent-variable (var)
   (goto-char (point-min))
-  (if (search-forward (concat "(setq " (symbol-name var) " '") nil t)
+  (if (let (case-fold-search)
+        (search-forward (concat "(setq " (symbol-name var) " '") nil t))
       (progn
 	(setq calc-pv-pos (point-marker))
 	(forward-line -1)
-- 
2.4.2





Reply sent to Wolfgang Jenkner <wjenkner <at> inode.at>:
You have taken responsibility. (Mon, 29 Jun 2015 12:56:02 GMT) Full text and rfc822 format available.

Notification sent to Wolfgang Jenkner <wjenkner <at> inode.at>:
bug acknowledged by developer. (Mon, 29 Jun 2015 12:56:03 GMT) Full text and rfc822 format available.

Message #10 received at 20916-done <at> debbugs.gnu.org (full text, mbox):

From: Wolfgang Jenkner <wjenkner <at> inode.at>
To: 20916-done <at> debbugs.gnu.org
Cc: jay.p.belanger <at> gmail.com
Subject: Re: bug#20916: 25.0.50; [PATCH] Calc `s p' glitch
Date: Mon, 29 Jun 2015 14:54:32 +0200
Version: 25.1

The Calc maintainer kindly replied in private email.

Pushed.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 28 Jul 2015 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 10 years and 23 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.