GNU bug report logs - #20761
beginning-of-defun matches column 0 paren inside string literal

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20761 in the body.
You can then email your comments to 20761 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50.1, beginning-of-defun matches inside string
Date: Sun, 07 Jun 2015 19:21:28 +0200

emacs -Q

With cursor at end of string below:

(defun asdf ()
  "
(defun foo1 (&optional beg end)
  sdsd"
)

;;;

C-M-a stops  inside string at "(defun foo1"

GNU Emacs 25.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.23) of 2015-06-07

Solution:

beginning-of-defun-raw must check if being inside string.

Message #8 received at 20761 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
Cc: 20761 <at> debbugs.gnu.org
Subject: Re: bug#20761: 25.0.50.1, beginning-of-defun matches inside string
Date: Sun, 07 Jun 2015 14:13:21 -0400

Andreas Röhler wrote:

> (defun asdf ()
>   "
> (defun foo1 (&optional beg end)
>   sdsd"
> )

Unescaped paren in column 0.

Message #15 received at 20761 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 20761 <at> debbugs.gnu.org
Subject: Re: bug#20761: 25.0.50.1, beginning-of-defun matches inside string
Date: Sun, 07 Jun 2015 20:41:28 +0200

Am 07.06.2015 um 20:13 schrieb Glenn Morris:
> Andreas Röhler wrote:
>
>> (defun asdf ()
>>    "
>> (defun foo1 (&optional beg end)
>>    sdsd"
>> )
> Unescaped paren in column 0.

Can't a string have that?

Message #18 received at 20761 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Richard <youngfrog <at> members.fsf.org>
To: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
Cc: Glenn Morris <rgm <at> gnu.org>, 20761 <at> debbugs.gnu.org
Subject: Re: bug#20761: 25.0.50.1, beginning-of-defun matches inside string
Date: Mon, 08 Jun 2015 07:18:26 +0200

Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:
> Am 07.06.2015 um 20:13 schrieb Glenn Morris:
>> Andreas Röhler wrote:
>>
>>> (defun asdf ()
>>>    "
>>> (defun foo1 (&optional beg end)
>>>    sdsd"
>>> )
>> Unescaped paren in column 0.
>
> Can't a string have that?

They can, but the convention is to not do that :
(info "(emacs) Left Margin Paren")

It's also in the docstring of beginning-of-defun
> When `open-paren-in-column-0-is-defun-start' is non-nil, a defun
> is assumed to start where there is a char with open-parenthesis
> syntax at the beginning of a line.

-- 
Nico.

Message #21 received at 20761 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: Nicolas Richard <youngfrog <at> members.fsf.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 20761 <at> debbugs.gnu.org
Subject: Re: bug#20761: 25.0.50.1, beginning-of-defun matches inside string
Date: Mon, 08 Jun 2015 07:45:40 +0200

Am 08.06.2015 um 07:18 schrieb Nicolas Richard:
> Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:
>> Am 07.06.2015 um 20:13 schrieb Glenn Morris:
>>> Andreas Röhler wrote:
>>>
>>>> (defun asdf ()
>>>>     "
>>>> (defun foo1 (&optional beg end)
>>>>     sdsd"
>>>> )
>>> Unescaped paren in column 0.
>> Can't a string have that?
> They can, but the convention is to not do that :
> (info "(emacs) Left Margin Paren")

An oddity from times, where parse-partial-sexp was not available, time 
to get rid of that.


> It's also in the docstring of beginning-of-defun
>> When `open-paren-in-column-0-is-defun-start' is non-nil, a defun
>> is assumed to start where there is a char with open-parenthesis
>> syntax at the beginning of a line.

Ditto, just legacy, no need for that.

Message #24 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#20761: 25.0.50.1, beginning-of-defun matches inside string
Date: Mon, 08 Jun 2015 11:09:35 +0200

Am 07.06.2015 um 19:21 schrieb Andreas Röhler:
> emacs -Q
>
> With cursor at end of string below:
>
> (defun asdf ()
>   "
> (defun foo1 (&optional beg end)
>   sdsd"
> )
>
> ;;;
>
> C-M-a stops  inside string at "(defun foo1"
>
> GNU Emacs 25.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.23) of 
> 2015-06-07
>
> Solution:
>
> beginning-of-defun-raw must check if being inside string.
>
>
>

This should fix it:

(defun ar-beginning-of-defun (&optional arg)
  "Move to the beginning of a function definition.

Returns position, if successful, nil otherwise

Calls `beginning-of-defun-function', when set "
  (interactive "P")
  (unless (bobp)
    (skip-chars-backward " \t\r\n\f")
    (forward-char -1)
    (let ((pos (car-safe (nth 9 (parse-partial-sexp (point-min) 
(point))))))
      (if beginning-of-defun-function
      (funcall beginning-of-defun-function arg)
    (and pos
         (goto-char pos))))))

Optional arg here is for special needs, switches between class and 
method defs for example.

Message #27 received at 20761 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
Cc: 20761 <at> debbugs.gnu.org
Subject: Re: bug#20761: 25.0.50.1, beginning-of-defun matches inside string
Date: Sun, 02 Apr 2017 01:18:06 -0400

retitle 20761 beginning-of-defun matches column 0 paren inside string literal
forcemerge 20761 20284
tags 20761 wontfix
quit

Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:

> This should fix it:
>
> (defun ar-beginning-of-defun (&optional arg)
>   "Move to the beginning of a function definition.
>
> Returns position, if successful, nil otherwise
>
> Calls `beginning-of-defun-function', when set "
>   (interactive "P")
>   (unless (bobp)
>     (skip-chars-backward " \t\r\n\f")
>     (forward-char -1)
>     (let ((pos (car-safe (nth 9 (parse-partial-sexp (point-min) (point))))))
>       (if beginning-of-defun-function
>       (funcall beginning-of-defun-function arg)
>     (and pos
>          (goto-char pos))))))

M-x find-library org RET
M->
(benchmark 1 '(ar-beginning-of-defun)) ; Elapsed time: 0.414771s, also it puts point in the wrong place
(benchmark 1 '(beginning-of-defun))    ; Elapsed time: 0.000126s
M-: (setq open-paren-in-column-0-is-defun-start nil)
(benchmark 1 '(beginning-of-defun))    ; Elapsed time: 0.002505s

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.