GNU bug report logs - #20554
Fwd: Minor bug in dunnet

Previous Next

Package: emacs;

Reported by: Lu Wang <coolwanglu <at> gmail.com>

Date: Tue, 12 May 2015 03:19:02 UTC

Severity: normal

Fixed in version 25.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#20554: closed (Fwd: Minor bug in dunnet)
Date: Tue, 12 May 2015 06:48:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 12 May 2015 02:47:03 -0400
with message-id <213832jnrs.fsf <at> fencepost.gnu.org>
and subject line Re: bug#20554: Fwd: Minor bug in dunnet
has caused the debbugs.gnu.org bug report #20554,
regarding Fwd: Minor bug in dunnet
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
20554: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20554
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Lu Wang <coolwanglu <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Fwd: Minor bug in dunnet
Date: Tue, 12 May 2015 11:02:45 +0800
[Message part 3 (text/plain, inline)]
Hello,

  (Sorry I have posted this email to -devel by mistake)

  It seems to me that in dunnet, the line that extracts the current time is
offset by 1.  You may try to eval:

(substring (current-time-string) 11 19)
and
(substring (current-time-string) 12 20)


  While I believe that the game must have once worked with earlier versions
of emacs, I'm not sure if (substring) or (current-time-string) has been
changed since then.


  Please find the patch below.


  Thanks!

  regards,
  - Lu Wang

/////
diff --git a/lisp/play/dunnet.el b/lisp/play/dunnet.el
index 2f4536c..2d1a58f 100644
--- a/dunnet.el
+++ b/dunnet.el
@@ -3099,7 +3099,7 @@ File not found")))
 (defun dun-dos-boot-msg ()
   (sleep-for 3)
   (dun-mprinc "Current time is ")
-  (dun-mprincl (substring (current-time-string) 12 20))
+  (dun-mprincl (substring (current-time-string) 11 19))
   (dun-mprinc "Enter new time: ")
   (dun-read-line)
   (if (not dun-batch-mode)
[Message part 4 (text/html, inline)]
[Message part 5 (message/rfc822, inline)]
From: Glenn Morris <rgm <at> gnu.org>
To: 20554-done <at> debbugs.gnu.org
Subject: Re: bug#20554: Fwd: Minor bug in dunnet
Date: Tue, 12 May 2015 02:47:03 -0400
Version: 25.1

Thanks; fixed.


This bug report was last modified 10 years and 74 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.