GNU bug report logs - #20554
Fwd: Minor bug in dunnet

Previous Next

Package: emacs;

Reported by: Lu Wang <coolwanglu <at> gmail.com>

Date: Tue, 12 May 2015 03:19:02 UTC

Severity: normal

Fixed in version 25.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20554 in the body.
You can then email your comments to 20554 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#20554; Package emacs. (Tue, 12 May 2015 03:19:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Lu Wang <coolwanglu <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 12 May 2015 03:19:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lu Wang <coolwanglu <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Fwd: Minor bug in dunnet
Date: Tue, 12 May 2015 11:02:45 +0800
[Message part 1 (text/plain, inline)]
Hello,

  (Sorry I have posted this email to -devel by mistake)

  It seems to me that in dunnet, the line that extracts the current time is
offset by 1.  You may try to eval:

(substring (current-time-string) 11 19)
and
(substring (current-time-string) 12 20)


  While I believe that the game must have once worked with earlier versions
of emacs, I'm not sure if (substring) or (current-time-string) has been
changed since then.


  Please find the patch below.


  Thanks!

  regards,
  - Lu Wang

/////
diff --git a/lisp/play/dunnet.el b/lisp/play/dunnet.el
index 2f4536c..2d1a58f 100644
--- a/dunnet.el
+++ b/dunnet.el
@@ -3099,7 +3099,7 @@ File not found")))
 (defun dun-dos-boot-msg ()
   (sleep-for 3)
   (dun-mprinc "Current time is ")
-  (dun-mprincl (substring (current-time-string) 12 20))
+  (dun-mprincl (substring (current-time-string) 11 19))
   (dun-mprinc "Enter new time: ")
   (dun-read-line)
   (if (not dun-batch-mode)
[Message part 2 (text/html, inline)]

Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Tue, 12 May 2015 06:48:02 GMT) Full text and rfc822 format available.

Notification sent to Lu Wang <coolwanglu <at> gmail.com>:
bug acknowledged by developer. (Tue, 12 May 2015 06:48:02 GMT) Full text and rfc822 format available.

Message #10 received at 20554-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 20554-done <at> debbugs.gnu.org
Subject: Re: bug#20554: Fwd: Minor bug in dunnet
Date: Tue, 12 May 2015 02:47:03 -0400
Version: 25.1

Thanks; fixed.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 09 Jun 2015 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 10 years and 73 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.