GNU bug report logs - #20414
Fwd: lunar.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20414 in the body.
You can then email your comments to 20414 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicholas Strauss <nicholas.strauss <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Fwd: lunar.el
Date: Thu, 23 Apr 2015 15:04:02 -0700

[Message part 1 (text/plain, inline)]

Hi bug-gnu-emacs,

Here is an updated M-x lunar phases that displays lunar and solar
eclipses. I created this from lunar.el and lunar.el.ncs using diff -cw.

I'm attaching output.

I was motivated to do this while observing the lunar eclipse
of April 4, 2015 in Oklahoma.

Nick


---------- Forwarded message ----------
From: Glenn Morris <rgm <at> gnu.org>
Date: Thu, Apr 23, 2015 at 11:39 AM
Subject: Re: lunar.el
To: Nicholas Strauss <nicholas.strauss <at> gmail.com>
Cc: reingold <at> cs.uiuc.edu, Richard Stallman <rms <at> gnu.org>



Thanks. Please send this in the form of a patch plus explanation of
changes to bug-gnu-emacs <at> gnu.org. One way to create the patch is

diff -cw lunar.el.ORIGINAL lunar.el.YOURVERSION

Even better is to base your patch on the current git version;
http://savannah.gnu.org/git/?group=emacs .

[lunar-output.txt (text/plain, attachment)]

[lunar.el.ncs-diffs (application/octet-stream, attachment)]

Message #8 received at 20414 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Nicholas Strauss <nicholas.strauss <at> gmail.com>
Cc: 20414 <at> debbugs.gnu.org
Subject: Re: bug#20414: Fwd: lunar.el
Date: Mon, 18 May 2015 03:01:44 -0400

Thanks for this.
What's the difference between "eclipse" and "eclipse possible"?

It predicts eclipses when the moon is quarter-full, which seems wrong?

Tuesday, June 9, 2015: Last Quarter Moon 8:48am (PDT) **  Eclipse possible **
Tuesday, June 16, 2015: New Moon 7:08am (PDT) 
Wednesday, June 24, 2015: First Quarter Moon 4:04am (PDT) **  Eclipse **

Message #11 received at 20414 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 20414 <at> debbugs.gnu.org, Nicholas Strauss <nicholas.strauss <at> gmail.com>
Subject: Re: bug#20414: Fwd: lunar.el
Date: Tue, 23 Feb 2016 21:42:08 +1100

Glenn Morris <rgm <at> gnu.org> writes:

> Thanks for this.
> What's the difference between "eclipse" and "eclipse possible"?
>
> It predicts eclipses when the moon is quarter-full, which seems wrong?
>
> Tuesday, June 9, 2015: Last Quarter Moon 8:48am (PDT) **  Eclipse possible **
> Tuesday, June 16, 2015: New Moon 7:08am (PDT) 
> Wednesday, June 24, 2015: First Quarter Moon 4:04am (PDT) **  Eclipse **

It seems like a fun addition to lunar.el, but if it's wrong, it's...
not.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 20414 <at> debbugs.gnu.org (full text, mbox):

From: Nicholas Strauss <nicholas.strauss <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 20414 <at> debbugs.gnu.org
Subject: Re: bug#20414: Fwd: lunar.el
Date: Tue, 23 Feb 2016 14:01:47 -0800

[Message part 1 (text/plain, inline)]

Hi Lars,

The Calendar already computed Moon's latitude and longitude -- I was
just reuse for eclipses.

 The first right/wrong test is to determine if this is theoretically right.

    (if (or (= phase 0)
            (= phase 2))
        (cond ((< moon-lat 2.42600766e-1)
           (concat "** " phase-name " Eclipse **"))
              ((< moon-lat 0.37)
               (concat "** " phase-name " Eclipse possible **"))
              (t
               "")
              )


 2nd test is to compare predictions --  100 years run (modify
emacs/lisp/calendar/lunar.el)
NASA web page ( http://eclipse.gsfc.nasa.gov/LEdecade/LEdecade2011.html )

I'm attaching my mutated lunar.el and a 100 year table.

If you're interested, I can discuss where those magic numbers come from.

:0
Nick

On Tue, Feb 23, 2016 at 2:42 AM, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
> Glenn Morris <rgm <at> gnu.org> writes:
>
>> Thanks for this.
>> What's the difference between "eclipse" and "eclipse possible"?
>>
>> It predicts eclipses when the moon is quarter-full, which seems wrong?
>>
>> Tuesday, June 9, 2015: Last Quarter Moon 8:48am (PDT) **  Eclipse possible **
>> Tuesday, June 16, 2015: New Moon 7:08am (PDT)
>> Wednesday, June 24, 2015: First Quarter Moon 4:04am (PDT) **  Eclipse **
>
> It seems like a fun addition to lunar.el, but if it's wrong, it's...
> not.  :-)
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

[lunar-eclipses-2016-2116.txt (text/plain, attachment)]

[lunar.el.ncs (application/octet-stream, attachment)]

Message #19 received at 20414 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Nicholas Strauss <nicholas.strauss <at> gmail.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 20414 <at> debbugs.gnu.org
Subject: Re: bug#20414: Fwd: lunar.el
Date: Tue, 25 Jun 2019 19:31:41 +0200

[Message part 1 (text/plain, inline)]

Nicholas Strauss <nicholas.strauss <at> gmail.com> writes:

>  2nd test is to compare predictions --  100 years run (modify
> emacs/lisp/calendar/lunar.el)
> NASA web page ( http://eclipse.gsfc.nasa.gov/LEdecade/LEdecade2011.html )
>
> I'm attaching my mutated lunar.el and a 100 year table.

Sounds great.  I was going to apply your patch (after changing it
coding-standards-wise slightly), but then I saw that you didn't have
copyright papers on file.  (I thought I remembered your name, but it was
a different Strauss.)

The change is big enough that a copyright assignment to the Free
Software Foundation is needed -- would you be willing to sign such
paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

[lunar.diff (text/x-diff, attachment)]

Message #24 received at 20414 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 20414 <at> debbugs.gnu.org,
 Nicholas Strauss <nicholas.strauss <at> gmail.com>
Subject: Re: bug#20414: Fwd: lunar.el
Date: Mon, 20 Jan 2020 22:12:39 +0100

Hi Nicholas,

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Nicholas Strauss <nicholas.strauss <at> gmail.com> writes:
>
>>  2nd test is to compare predictions --  100 years run (modify
>> emacs/lisp/calendar/lunar.el)
>> NASA web page ( http://eclipse.gsfc.nasa.gov/LEdecade/LEdecade2011.html )
>>
>> I'm attaching my mutated lunar.el and a 100 year table.
>
> Sounds great.  I was going to apply your patch (after changing it
> coding-standards-wise slightly), but then I saw that you didn't have
> copyright papers on file.  (I thought I remembered your name, but it was
> a different Strauss.)
>
> The change is big enough that a copyright assignment to the Free
> Software Foundation is needed -- would you be willing to sign such
> paperwork?

We still need a copyright assignment to apply your patch.  Would you
be willing to sign such papers?  It is a simple procedure that all
developers of Emacs goes through.  You can find more about the reasons
why we have that requirement here:

    https://www.gnu.org/licenses/why-assign.html

Looking forward to your reply.

Best regards,
Stefan Kangas

Message #27 received at 20414 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 20414 <at> debbugs.gnu.org,
 Nicholas Strauss <nicholas.strauss <at> gmail.com>
Subject: Re: bug#20414: Fwd: lunar.el
Date: Tue, 21 Jan 2020 00:03:12 +0100

Nicholas has informed me that he submitted his completed paperwork to
the FSF copyright clerk on August 13, 2019.

Lars, could you please verify that we have that on file, and then
install this on master with your changes?

Thanks in advance.

Best regards,
Stefan Kangas

Message #30 received at 20414 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: larsi <at> gnus.org, 20414 <at> debbugs.gnu.org, nicholas.strauss <at> gmail.com
Subject: Re: bug#20414: Fwd: lunar.el
Date: Tue, 21 Jan 2020 05:33:16 +0200

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Tue, 21 Jan 2020 00:03:12 +0100
> Cc: 20414 <at> debbugs.gnu.org, Nicholas Strauss <nicholas.strauss <at> gmail.com>
> 
> Nicholas has informed me that he submitted his completed paperwork to
> the FSF copyright clerk on August 13, 2019.
> 
> Lars, could you please verify that we have that on file

We do have Nicholas's assignment on file.

Message #33 received at 20414 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 20414 <at> debbugs.gnu.org, Stefan Kangas <stefan <at> marxist.se>,
 nicholas.strauss <at> gmail.com
Subject: Re: bug#20414: Fwd: lunar.el
Date: Wed, 22 Jan 2020 15:14:36 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Nicholas has informed me that he submitted his completed paperwork to
>> the FSF copyright clerk on August 13, 2019.
>> 
>> Lars, could you please verify that we have that on file
>
> We do have Nicholas's assignment on file.

OK; I've now applied Nicholas's patch to Emacs 28.  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.