GNU bug report logs - #20309
25.0.50; Coding conversion error during clojure-mode package upgrade

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20309 in the body.
You can then email your comments to 20309 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; Coding conversion error during clojure-mode package upgrade
Date: Sun, 12 Apr 2015 16:46:26 +0300

[Message part 1 (text/plain, inline)]

The package is being installed from MELPA, the file can be viewed at
http://melpa.org/packages/clojure-mode-20150410.2319.el.

Viewing it in the browser (or downloading and opening in `less')
displays those copyright characters just fine.

Not so here, see the attached screenshot.

[Screenshot from 2015-04-12 16:17:23.png (image/png, attachment)]

[Message part 3 (text/plain, inline)]

In GNU Emacs 25.0.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2)
 of 2015-04-12 on axl
Repository revision: d0fcb21254394e22542dbc350220db3bafe0cc13
Windowing system distributor `The X.Org Foundation', version 11.0.11601901
System Description:	Ubuntu 14.10

Message #10 received at 20309 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 20309 <at> debbugs.gnu.org
Subject: Re: bug#20309: 25.0.50; Coding conversion error during clojure-mode
 package upgrade
Date: Tue, 22 Oct 2019 02:57:59 +0200

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> The package is being installed from MELPA, the file can be viewed at
> http://melpa.org/packages/clojure-mode-20150410.2319.el.

The latest version seems to be available here:
https://raw.githubusercontent.com/clojure-emacs/clojure-mode/master/clojure-mode.el

> Viewing it in the browser (or downloading and opening in `less')
> displays those copyright characters just fine.
>
> Not so here, see the attached screenshot.

I can't reproduce this on current master.  I believe that it has been
fixed by the following commit (if not before):

commit 5f9671e57ee99cfe4653b2cb6aca16d52f9a5c53
Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
Date:   Sat May 18 18:32:47 2019 -0400

    * lisp/emacs-lisp/package.el: Fix decoding of downloaded files

    This is a different fix for bug#34909, which should also fix bug#35739.

    Our downloading code used to automatically decode the result according
    to the usual heuristics for files.  This caused problems when we later
    needed to save the data in a file that needed to be byte-for-byte
    equal to the original in order to pass the signature verification,
    especially because we didn't keep track of which coding-system was
    used to decode the data.

There is also a separate fix installed on the now released Emacs 26.3.

Could you please test this on Emacs 26.3 or the current master branch
and see if it works for you?

If I don't hear back from you within a couple of weeks, I'll just close
this as unreproducible.

Best regards,
Stefan Kangas

Message #13 received at 20309 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: steckerhalter <emacs <at> postmomentum.ch>
Cc: 20309 <at> debbugs.gnu.org, 21319 <at> debbugs.gnu.org
Subject: Re: bug#21319: `package-install-file' fails with CRLF (Windows) line
 endings
Date: Tue, 22 Oct 2019 03:04:59 +0200

steckerhalter <emacs <at> postmomentum.ch> writes:

> package.el contains this code:
>
> (defun package-install-file (file)
>   "Install a package from a file.
> The file can either be a tar file or an Emacs Lisp file."
>   (interactive "fPackage file name: ")
>   (with-temp-buffer
>     (insert-file-contents-literally file)
>     (when (string-match "\\.tar\\'" file) (tar-mode))
>     (package-install-from-buffer)))
>
> Since `insert-file-contents-literally' does not do any conversion
> `package-buffer-info' fails to parse the info if the file is .el and
> contains CRLF line endings. It then errors out with:
>
> Debugger entered--Lisp error: (error "Package lacks a \"Version\" or
> \"Package-Version\" header")
>   signal(error ("Package lacks a \"Version\" or \"Package-Version\" header"))
>   error("Package lacks a \"Version\" or \"Package-Version\" header")
>   package-buffer-info()
>
> This affects all recent Emacs versions (including trunk).

This was reported 4 years ago, but unfortunately never got a reply at
the time.

Are you still seeing this on a recent version of Emacs?  If yes, could
you please provide a minimal example file which fails to install?

Also, why does your file have these line endings in the first place?
Was this file written in Emacs?  I'm trying to understand if this is
an important use case or the common scenario for users of MS-Windows,
since I don't use it myself.

Best regards,
Stefan Kangas

Message #18 received at 20309-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 20309-done <at> debbugs.gnu.org
Subject: Re: bug#20309: 25.0.50; Coding conversion error during clojure-mode
 package upgrade
Date: Tue, 22 Oct 2019 16:03:12 +0300

On 22.10.2019 3:57, Stefan Kangas wrote:
> I can't reproduce this on current master.  I believe that it has been
> fixed by the following commit (if not before)

Thank you for the reminder.

I haven't seen this lately, so: closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.