GNU bug report logs - #1975
Reusing dead shell buffers

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Chong Yidong <cyd <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#1975: closed (Reusing dead shell buffers)
Date: Fri, 30 Nov 2012 08:09:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 30 Nov 2012 16:06:33 +0800
with message-id <87obifldkm.fsf <at> gnu.org>
and subject line Re: bug#1975: Reusing dead shell buffers
has caused the debbugs.gnu.org bug report #1975,
regarding Reusing dead shell buffers
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
1975: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=1975
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: jemarch <at> gnu.org
To: quiet <at> debbugs.gnu.org
Subject: Reusing dead shell buffers
Date: Sun, 11 Jan 2009 21:19:21 +0100

Severity: wishlist

[ resent from
  http://lists.gnu.org/archive/html/emacs-devel/2009-01/msg00295.html ]

Hi.

Just a tiny patch for shell.

The patch assumes that the person launching M-xshell while in a
shell-mode buffer with a terminated process really wants to launch a
shell process in the current buffer instead to switch to "*shell*".

The semantics of C-uM-xshell are not changed by the patch.

Index: shell.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/shell.el,v
retrieving revision 1.165
diff -u -r1.165 shell.el
--- shell.el	5 Jan 2009 03:19:45 -0000	1.165
+++ shell.el	11 Jan 2009 19:46:35 -0000
@@ -555,6 +555,9 @@
 		      (read-file-name
 		       "Default directory: " default-directory default-directory
 		       t nil 'file-directory-p))))))))
+  ;; If the current buffer is a dead shell buffer, use it.
+  (if (and (not buffer) (eq major-mode 'shell-mode))
+      (setq buffer (current-buffer)))
   (setq buffer (get-buffer-create (or buffer "*shell*")))
   ;; Pop to buffer, so that the buffer's window will be correctly set
   ;; when we call comint (so that comint sets the COLUMNS env var properly).

[Message part 3 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> gnu.org>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 1975-done <at> debbugs.gnu.org, "Jose E. Marchesi" <jemarch <at> gnu.org>
Subject: Re: bug#1975: Reusing dead shell buffers
Date: Fri, 30 Nov 2012 16:06:33 +0800

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

> Currently `C-u M-x shell' defaults to "*shell*", which seems pretty
> nonsensical.  Surely if the user wanted to use that buffer, then she
> would have just typed `M-x shell'.
>
> So perhaps `C-u M-x shell' should just default to the current buffer
> instead?

Agreed.  Implemented in trunk.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.