GNU bug report logs - #19743
'wrap-program' should preserve symbolic links

Previous Next

Package: guix;

Reported by: ludo <at> gnu.org (Ludovic Courtès)

Date: Sun, 1 Feb 2015 23:32:03 UTC

Severity: normal

Done: Andreas Enge <andreas <at> enge.fr>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Subject: bug#19743: closed (Close)
Date: Mon, 16 Feb 2015 14:28:04 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#19743: 'wrap-program' should preserve symbolic links

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 19743 <at> debbugs.gnu.org.

-- 
19743: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19743
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Andreas Enge <andreas <at> enge.fr>
To: 19743-done <at> debbugs.gnu.org
Subject: Close
Date: Mon, 16 Feb 2015 15:27:20 +0100
Applied in commit da466f7ff63e34aca271e603090f25ba471f009e.

Andreas


[Message part 3 (message/rfc822, inline)]
From: ludo <at> gnu.org (Ludovic Courtès)
To: bug-guix <at> gnu.org
Subject: 'wrap-program' should preserve symbolic links
Date: Sun, 01 Feb 2015 22:41:57 +0100
[Message part 4 (text/plain, inline)]
When ‘wrap-program’ is called on a symbolic link, it should preserve its
symboliclinkness instead of copying it.

Ludo’.

[Message part 5 (text/x-patch, inline)]
diff --git a/guix/build/utils.scm b/guix/build/utils.scm
index 4407f9a..56f682c 100644
--- a/guix/build/utils.scm
+++ b/guix/build/utils.scm
@@ -837,7 +837,7 @@ the previous wrapper."
     (if (zero? number)
         (let ((prog-real (string-append (dirname prog) "/."
                                         (basename prog) "-real")))
-          (copy-file prog prog-real)
+          (rename-file prog prog-real)
           prog-real)
         (wrapper-file-name number)))
 

This bug report was last modified 10 years and 151 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.