GNU bug report logs - #19743
'wrap-program' should preserve symbolic links

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19743 in the body.
You can then email your comments to 19743 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: bug-guix <at> gnu.org
Subject: 'wrap-program' should preserve symbolic links
Date: Sun, 01 Feb 2015 22:41:57 +0100

[Message part 1 (text/plain, inline)]

When ‘wrap-program’ is called on a symbolic link, it should preserve its
symboliclinkness instead of copying it.

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/guix/build/utils.scm b/guix/build/utils.scm
index 4407f9a..56f682c 100644
--- a/guix/build/utils.scm
+++ b/guix/build/utils.scm
@@ -837,7 +837,7 @@ the previous wrapper."
     (if (zero? number)
         (let ((prog-real (string-append (dirname prog) "/."
                                         (basename prog) "-real")))
-          (copy-file prog prog-real)
+          (rename-file prog prog-real)
           prog-real)
         (wrapper-file-name number)))
 

Message #10 received at 19743-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 19743-done <at> debbugs.gnu.org
Subject: Close
Date: Mon, 16 Feb 2015 15:27:20 +0100

Applied in commit da466f7ff63e34aca271e603090f25ba471f009e.

Andreas

Message #13 received at 19743 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas <at> enge.fr>
Cc: 19743 <at> debbugs.gnu.org
Subject: Re: bug#19743: 'wrap-program' should preserve symbolic links
Date: Mon, 23 Feb 2015 20:45:00 +0100

Andreas Enge <andreas <at> enge.fr> skribis:

> From cced64ffd33754434d732c552bdbb5c038891a8d Mon Sep 17 00:00:00 2001
> From: Andreas Enge <andreas <at> enge.fr>
> Date: Sun, 15 Feb 2015 17:40:17 +0100
> Subject: [PATCH] utils: Preserve symbolic links in 'wrap-program'.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * guix/build/utils.scm (wrap-program): Preserve symbolic links instead of
>     copying the contents of the link.
    ^^
No extra space here please.

> Co-authored-by: Ludovic Courtès <ludo <at> gnu.org>
>
> Closes <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19743>.

Use “Fixes: ...” as in the other commits.

OK for ‘core-updates’.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.