GNU bug report logs - #19506
25.0.50; [PATCH] Use conf-mode for VC config files

Previous Next

Package: emacs;

Reported by: Eduard Wiebe <usenet <at> pusto.de>

Date: Sun, 4 Jan 2015 18:27:02 UTC

Severity: wishlist

Tags: patch

Found in version 25.0.50

Fixed in version 25.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eduard Wiebe <usenet <at> pusto.de>
Subject: bug#19506: closed (Re: bug#19506: 25.0.50; [PATCH] Use conf-mode
 for VC config files)
Date: Sun, 19 Apr 2015 01:38:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#19506: 25.0.50; [PATCH] Use conf-mode for VC config files

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 19506 <at> debbugs.gnu.org.

-- 
19506: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19506
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Glenn Morris <rgm <at> gnu.org>
To: 19506-done <at> debbugs.gnu.org
Subject: Re: bug#19506: 25.0.50; [PATCH] Use conf-mode for VC config files
Date: Sat, 18 Apr 2015 21:37:14 -0400
Version: 25.1

Eduard Wiebe wrote:

> --- a/lisp/files.el
> +++ b/lisp/files.el
> @@ -2522,6 +2522,9 @@ ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|7Z\\)\\'" . archive-mode)
>       ("/config\\.\\(?:bat\\|log\\)\\'" . fundamental-mode)
>       ;; Windows candidates may be opened case sensitively on Unix
>       ("\\.\\(?:[iI][nN][iI]\\|[lL][sS][tT]\\|[rR][eE][gG]\\|[sS][yY][sS]\\)\\'" . conf-mode)
> +     ("\\(?:\\.bzrignore\\|\\.bazaar/ignore\\)\\'" . conf-mode)
> +     ("\\(?:\\.hgignore\\|\\.?hgrc\\)\\'" . conf-mode)
> +     ("\\(?:\\.git\\(ignore\\|attributes\\)\\|\\.?gitconfig\\|\\.git/info/\\(?:exclude\\|attributes\\)\\)\\'" . conf-mode)
>       ("\\.\\(?:desktop\\|la\\)\\'" . conf-unix-mode)
>       ("\\.ppd\\'" . conf-ppd-mode)
>       ("java.+\\.conf\\'" . conf-javaprop-mode)


As I see it, conf-mode is useful for things that contain
"var=value" statements.

bzrignore, bazaar/ignore, .hgignore, .gitignore, .git/info/exclude
  do not

.gitconfig and .hgrc do.
.gitattributes sort of does, maybe.
.git/info/attributes seems like overkill.


So I added just .gitconfig and .hgrc.

[Message part 3 (message/rfc822, inline)]
From: Eduard Wiebe <usenet <at> pusto.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; [PATCH] Use conf-mode for VC config files
Date: Sun, 04 Jan 2015 19:22:46 +0100
 Hi,

any concerns to add this tiny change?

* files.el (auto-mode-alist): Use `conf-mode' for Bzr, Git, and Hg
  config files.
---
 lisp/ChangeLog |    7 +++++++
 lisp/files.el  |    3 +++
 2 files changed, 10 insertions(+)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index f62dc07..8f27b42 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,10 @@
+2015-01-04  Eduard Wiebe  <usenet <at> pusto.de>
+
+	Use conf-mode for VC config files.
+
+	* files.el (auto-mode-alist): Use `conf-mode' for Bzr, Git, and Hg
+	config files.
+
 2015-01-04  Paul Eggert  <eggert <at> cs.ucla.edu>
 
 	Less 'make' chatter for lisp dir
diff --git a/lisp/files.el b/lisp/files.el
index 80b538c..44ef910 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -2522,6 +2522,9 @@ ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|7Z\\)\\'" . archive-mode)
      ("/config\\.\\(?:bat\\|log\\)\\'" . fundamental-mode)
      ;; Windows candidates may be opened case sensitively on Unix
      ("\\.\\(?:[iI][nN][iI]\\|[lL][sS][tT]\\|[rR][eE][gG]\\|[sS][yY][sS]\\)\\'" . conf-mode)
+     ("\\(?:\\.bzrignore\\|\\.bazaar/ignore\\)\\'" . conf-mode)
+     ("\\(?:\\.hgignore\\|\\.?hgrc\\)\\'" . conf-mode)
+     ("\\(?:\\.git\\(ignore\\|attributes\\)\\|\\.?gitconfig\\|\\.git/info/\\(?:exclude\\|attributes\\)\\)\\'" . conf-mode)
      ("\\.\\(?:desktop\\|la\\)\\'" . conf-unix-mode)
      ("\\.ppd\\'" . conf-ppd-mode)
      ("java.+\\.conf\\'" . conf-javaprop-mode)

--
Eduard Wiebe



This bug report was last modified 10 years and 36 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.