GNU bug report logs - #19506
25.0.50; [PATCH] Use conf-mode for VC config files

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19506 in the body.
You can then email your comments to 19506 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eduard Wiebe <usenet <at> pusto.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; [PATCH] Use conf-mode for VC config files
Date: Sun, 04 Jan 2015 19:22:46 +0100

 Hi,

any concerns to add this tiny change?

* files.el (auto-mode-alist): Use `conf-mode' for Bzr, Git, and Hg
  config files.
---
 lisp/ChangeLog |    7 +++++++
 lisp/files.el  |    3 +++
 2 files changed, 10 insertions(+)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index f62dc07..8f27b42 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,10 @@
+2015-01-04  Eduard Wiebe  <usenet <at> pusto.de>
+
+	Use conf-mode for VC config files.
+
+	* files.el (auto-mode-alist): Use `conf-mode' for Bzr, Git, and Hg
+	config files.
+
 2015-01-04  Paul Eggert  <eggert <at> cs.ucla.edu>
 
 	Less 'make' chatter for lisp dir
diff --git a/lisp/files.el b/lisp/files.el
index 80b538c..44ef910 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -2522,6 +2522,9 @@ ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|7Z\\)\\'" . archive-mode)
      ("/config\\.\\(?:bat\\|log\\)\\'" . fundamental-mode)
      ;; Windows candidates may be opened case sensitively on Unix
      ("\\.\\(?:[iI][nN][iI]\\|[lL][sS][tT]\\|[rR][eE][gG]\\|[sS][yY][sS]\\)\\'" . conf-mode)
+     ("\\(?:\\.bzrignore\\|\\.bazaar/ignore\\)\\'" . conf-mode)
+     ("\\(?:\\.hgignore\\|\\.?hgrc\\)\\'" . conf-mode)
+     ("\\(?:\\.git\\(ignore\\|attributes\\)\\|\\.?gitconfig\\|\\.git/info/\\(?:exclude\\|attributes\\)\\)\\'" . conf-mode)
      ("\\.\\(?:desktop\\|la\\)\\'" . conf-unix-mode)
      ("\\.ppd\\'" . conf-ppd-mode)
      ("java.+\\.conf\\'" . conf-javaprop-mode)

--
Eduard Wiebe

Message #10 received at 19506-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 19506-done <at> debbugs.gnu.org
Subject: Re: bug#19506: 25.0.50; [PATCH] Use conf-mode for VC config files
Date: Sat, 18 Apr 2015 21:37:14 -0400

Version: 25.1

Eduard Wiebe wrote:

> --- a/lisp/files.el
> +++ b/lisp/files.el
> @@ -2522,6 +2522,9 @@ ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|7Z\\)\\'" . archive-mode)
>       ("/config\\.\\(?:bat\\|log\\)\\'" . fundamental-mode)
>       ;; Windows candidates may be opened case sensitively on Unix
>       ("\\.\\(?:[iI][nN][iI]\\|[lL][sS][tT]\\|[rR][eE][gG]\\|[sS][yY][sS]\\)\\'" . conf-mode)
> +     ("\\(?:\\.bzrignore\\|\\.bazaar/ignore\\)\\'" . conf-mode)
> +     ("\\(?:\\.hgignore\\|\\.?hgrc\\)\\'" . conf-mode)
> +     ("\\(?:\\.git\\(ignore\\|attributes\\)\\|\\.?gitconfig\\|\\.git/info/\\(?:exclude\\|attributes\\)\\)\\'" . conf-mode)
>       ("\\.\\(?:desktop\\|la\\)\\'" . conf-unix-mode)
>       ("\\.ppd\\'" . conf-ppd-mode)
>       ("java.+\\.conf\\'" . conf-javaprop-mode)


As I see it, conf-mode is useful for things that contain
"var=value" statements.

bzrignore, bazaar/ignore, .hgignore, .gitignore, .git/info/exclude
  do not

.gitconfig and .hgrc do.
.gitattributes sort of does, maybe.
.git/info/attributes seems like overkill.


So I added just .gitconfig and .hgrc.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.