GNU bug report logs - #19469
minor nit: (sxml xpath) node-typeof?

Previous Next

Package: guile;

Reported by: Matt Wette <mwette <at> alumni.caltech.edu>

Date: Tue, 30 Dec 2014 02:59:02 UTC

Severity: normal

Done: Andy Wingo <wingo <at> pobox.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andy Wingo <wingo <at> pobox.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#19469: closed (minor nit: (sxml xpath) node-typeof?)
Date: Wed, 22 Jun 2016 20:42:01 +0000

[Message part 1 (text/plain, inline)]
Your message dated Wed, 22 Jun 2016 22:41:00 +0200
with message-id <87r3bpq7mr.fsf <at> pobox.com>
and subject line Re: bug#19469: minor nit: (sxml xpath) node-typeof?
has caused the debbugs.gnu.org bug report #19469,
regarding minor nit: (sxml xpath) node-typeof?
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
19469: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19469
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: Matt Wette <mwette <at> alumni.caltech.edu>
To: bug-guile <at> gnu.org
Subject: minor nit: (sxml xpath) node-typeof?
Date: Mon, 29 Dec 2014 17:57:35 -0800

In guile-2.0.11 the following appears in sxml/xpath.scm:

(define (node-typeof? crit)
  (lambda (node)
    (case crit
      ((*) (and (pair? node) (not (memq (car node) '(@ *PI*)))))
      ((*any*) #t)
      ((*text*) (string? node))
      (else
       (and (pair? node) (eq? crit (car node))))
)))

Would it be more efficient to swap the "(lambda (node)" and "(case crit" forms?

Matt




[Message part 3 (message/rfc822, inline)]
From: Andy Wingo <wingo <at> pobox.com>
To: Matt Wette <mwette <at> alumni.caltech.edu>
Cc: 19469-done <at> debbugs.gnu.org
Subject: Re: bug#19469: minor nit: (sxml xpath) node-typeof?
Date: Wed, 22 Jun 2016 22:41:00 +0200

On Tue 09 Feb 2016 04:58, Matt Wette <mwette <at> alumni.caltech.edu> writes:

> I recommend that this bug be closed.  The current code is fine and consistent with the rest of the module. — Matt

OK :)  Patches accepted if there are improvements to make :)

A
This bug report was last modified 9 years and 27 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.