GNU bug report logs - #19469
minor nit: (sxml xpath) node-typeof?

Previous Next

Package: guile;

Reported by: Matt Wette <mwette <at> alumni.caltech.edu>

Date: Tue, 30 Dec 2014 02:59:02 UTC

Severity: normal

Done: Andy Wingo <wingo <at> pobox.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19469 in the body.
You can then email your comments to 19469 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-guile <at> gnu.org:
bug#19469; Package guile. (Tue, 30 Dec 2014 02:59:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Matt Wette <mwette <at> alumni.caltech.edu>:
New bug report received and forwarded. Copy sent to bug-guile <at> gnu.org. (Tue, 30 Dec 2014 02:59:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matt Wette <mwette <at> alumni.caltech.edu>
To: bug-guile <at> gnu.org
Subject: minor nit: (sxml xpath) node-typeof?
Date: Mon, 29 Dec 2014 17:57:35 -0800

In guile-2.0.11 the following appears in sxml/xpath.scm:

(define (node-typeof? crit)
  (lambda (node)
    (case crit
      ((*) (and (pair? node) (not (memq (car node) '(@ *PI*)))))
      ((*any*) #t)
      ((*text*) (string? node))
      (else
       (and (pair? node) (eq? crit (car node))))
)))

Would it be more efficient to swap the "(lambda (node)" and "(case crit" forms?

Matt
Information forwarded to bug-guile <at> gnu.org:
bug#19469; Package guile. (Tue, 09 Feb 2016 03:59:01 GMT) Full text and rfc822 format available.

Message #8 received at 19469 <at> debbugs.gnu.org (full text, mbox):

From: Matt Wette <mwette <at> alumni.caltech.edu>
To: 19469 <at> debbugs.gnu.org
Subject: minor nit: (sxml xpath) node-typeof?
Date: Mon, 8 Feb 2016 19:58:34 -0800

I recommend that this bug be closed.  The current code is fine and consistent with the rest of the module. — Matt
Reply sent to Andy Wingo <wingo <at> pobox.com>:
You have taken responsibility. (Wed, 22 Jun 2016 20:42:01 GMT) Full text and rfc822 format available.
Notification sent to Matt Wette <mwette <at> alumni.caltech.edu>:
bug acknowledged by developer. (Wed, 22 Jun 2016 20:42:02 GMT) Full text and rfc822 format available.

Message #13 received at 19469-done <at> debbugs.gnu.org (full text, mbox):

From: Andy Wingo <wingo <at> pobox.com>
To: Matt Wette <mwette <at> alumni.caltech.edu>
Cc: 19469-done <at> debbugs.gnu.org
Subject: Re: bug#19469: minor nit: (sxml xpath) node-typeof?
Date: Wed, 22 Jun 2016 22:41:00 +0200

On Tue 09 Feb 2016 04:58, Matt Wette <mwette <at> alumni.caltech.edu> writes:

> I recommend that this bug be closed.  The current code is fine and consistent with the rest of the module. — Matt

OK :)  Patches accepted if there are improvements to make :)

A
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 21 Jul 2016 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 9 years and 27 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.