GNU bug report logs - #19412
24.3; ido-write-file sometimes writes to a different directory than it says it will

Previous Next

Full log

Message #31 received at 19412 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Ryan C. Thompson" <rct <at> thompsonclan.org>
Cc: 19412 <at> debbugs.gnu.org, Stefan Kangas <stefan <at> marxist.se>
Subject: Re: bug#19412: 24.3; ido-write-file sometimes writes to a different
 directory than, it says it will
Date: Mon, 11 Jan 2021 15:14:50 +0100

"Ryan C. Thompson" <rct <at> thompsonclan.org> writes:

> It's been a while, but I've fixed up my patch and given it some
> testing, and it seems to work on for me. However, in the meantime,
> this issue has recently been "fixed" by special-casing write-file in
> ido.el, as seen in #28513. So if you want to install my patch now,
> you'll need to install the version attached to that thread. That
> version reverts the other fix, since of course they are not
> compatible, and would be redundant even if they were.

It looks like a more thorough fix.  However:

+          (minibuffer-with-setup-hook
+              (:append
+               (lambda ()
+                 ;; Clear out whatever started in the minibuffer and
+                 ;; replace it with what the user had already entered
+                 ;; into ido.
+                 (delete-minibuffer-contents)
+                 (insert (abbreviate-file-name ido-current-directory))))
+            (call-interactively this-command))))

I'd be worried that this would step on other modifications the user may
be doing from the minibuffer setup.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.