GNU bug report logs - #19377
[PATCH] OS/2 patches

Previous Next

Full log

Message #53 received at 19377-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: KO Myung-Hun <komh78 <at> gmail.com>
Cc: 19377-done <at> debbugs.gnu.org, Paul Eggert <eggert <at> cs.ucla.edu>,
 Pádraig Brady <P <at> draigbrady.com>
Subject: Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod,
 chown, cp, du, head: support wildcards on OS/2
Date: Thu, 18 Dec 2014 07:24:47 -0800

On Mon, Dec 15, 2014 at 9:11 PM, KO Myung-Hun <komh78 <at> gmail.com> wrote:
> Jim Meyering wrote:
>> On Mon, Dec 15, 2014 at 8:35 PM, KO Myung-Hun <komh78 <at> gmail.com> wrote:
>>> Paul Eggert wrote:
>>>> KO Myung-Hun wrote:
>>>>>   /* Redirection and wildcarding when done by the utility itself.
>>>>>      Generally a noop, but used in particular for native VMS. */
>>>>>   #ifndef initialize_main
>>>>> -# define initialize_main(ac, av)
>>>>> +# ifndef __OS2__
>>>>> +#  define initialize_main(ac, av)
>>>>> +# else
>>>>
>>>> What happened to VMS?  The comment doesn't seem to match the code, and
>>>
>>> I don't know of VMS. Do you mean to change comments for OS/2 ?
>>>
>>>> this suggests that the code should be moved to wherever VMS does its thing.
>>>
>>> Where is it ? I didn't find initialize_main() or others for VMS.
>>
>> It was never defined in any version-controlled file,
>> so please just update the comment, replacing VMS with OS/2.
>
> Ok. Fixed.

Thanks.
Pushed with minor grammar fixes in the commit log.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.