GNU bug report logs - #19377
[PATCH] OS/2 patches

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19377 in the body.
You can then email your comments to 19377 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: KO Myung-Hun <komh78 <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] OS/2 patches
Date: Sun, 14 Dec 2014 12:47:37 +0900

Hi/2.

These are OS/2 patches for coreutils.

Review, please...

[PATCH 1/4] doc: add $(EXEEXT) suffix to the executables
[PATCH 2/4] build: configure.ac: support a response file on OS/2
[PATCH 3/4] cat,chcon,chgrp,chmod,chown,cp,du,head: support wildcards
[PATCH 4/4] build: use -pi.bak instead of -pi

Message #10 received at 19377 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: KO Myung-Hun <komh78 <at> gmail.com>, 19377 <at> debbugs.gnu.org
Subject: Re: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du,
 head: support wildcards on OS/2
Date: Sun, 14 Dec 2014 13:17:50 +0000

forcemerge 19378 19377
stop

On 14/12/14 03:47, KO Myung-Hun wrote:
> And ln,ls,mv,rm,tail.
> 
> * src/cat.c (main): Expand wildcards on OS/2.
> * src/chcon.c (main): Likewise.
> * src/chgrp.c (main): Likewise.
> * src/chmod.c (main): Likewise.
> * src/chown.c (main): Likewise.
> * src/cp.c (main): Likewise.
> * src/du.c (main): Likewise.
> * src/head.c (main): Likewise.
> * src/ln.c (main): Likewise.
> * src/ls.c (main): Likewise.
> * src/mv.c (main): Likewise.
> * src/rm.c (main): Likewise.
> * src/tail.c (main): Likewise.
> 
> Patches from coreutils 8.8 by Paul Smedley.

> diff --git a/src/cat.c b/src/cat.c
> index c7bb7e1..0138114 100644
> --- a/src/cat.c
> +++ b/src/cat.c
> @@ -544,6 +544,10 @@ main (int argc, char **argv)
>    bool show_tabs = false;
>    int file_open_mode = O_RDONLY;
>  
> +#ifdef __OS2__
> +  _wildcard (&argc, &argv);
> +#endif
> +

Interesing, the OS/2 shell doesn't doe the globbing.
I'm wondering about the scalability of this.
Are there any facilities for dealing with arbitrary numbers
of files, like with xargs for example?
What are the practical limits of the number of files?
Does _wildcard() exit with an error in this case?

thanks,
Pádraig

Message #15 received at 19377 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: KO Myung-Hun <komh78 <at> gmail.com>, 19377 <at> debbugs.gnu.org
Subject: Re: bug#19376: [PATCH 4/4] build: use -pi.bak instead of -pi
Date: Sun, 14 Dec 2014 13:25:10 +0000

forcemerge 19376 19377
stop

On 14/12/14 03:47, KO Myung-Hun wrote:
> This fixes the following error.
> 
> -----
> Can't do inplace edit without backup.
> -----
> 
> * Makefile.am (dist-hook): Use -pi.bak instead of -pi.
> * bootstrap.conf (bootstrap_epilogue): Likewise.
> ---
>  Makefile.am    | 2 +-
>  bootstrap.conf | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index fb4af27..371eb59 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -105,7 +105,7 @@ BUILT_SOURCES = .version
>  # See the rm_subst comment for details.
>  dist-hook: gen-ChangeLog
>  	$(AM_V_GEN)echo $(VERSION) > $(distdir)/.tarball-version
> -	$(AM_V_at)perl -pi -e '$(rm_subst)' $(distdir)/Makefile.in
> +	$(AM_V_at)perl -pi.bak -e '$(rm_subst)' $(distdir)/Makefile.in
>  
>  gen_start_date = 2008-02-08
>  .PHONY: gen-ChangeLog
> diff --git a/bootstrap.conf b/bootstrap.conf
> index c0b5f02..0baf455 100644
> --- a/bootstrap.conf
> +++ b/bootstrap.conf
> @@ -366,7 +366,7 @@ bootstrap_epilogue()
>    # Why?  That pipeline searches all files in $(top_srcdir), and if you
>    # happen to have large files (or apparently large sparse files), the
>    # first grep may well run out of memory.
> -  perl -pi -e 's/if LC_ALL=C grep .GNU .PACKAGE.*; then/if true; then/' \
> +  perl -pi.bak -e 's/if LC_ALL=C grep .GNU .PACKAGE.*; then/if true; then/' \
>      po/Makefile.in.in
>  
>    # Install our git hooks, as long as "cp" accepts the --backup option,

This will leave .bak files in place on all platforms which isn't ideal.
Pity `perl -i` doesn't handle the platform differences transparently.
Does sed -i behave better. That's less portable though could be tried
and then fall back to perl -i.

thanks,
Pádraig.

Message #18 received at 19377 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Pádraig Brady <P <at> draigbrady.com>
Cc: 19377 <at> debbugs.gnu.org, KO Myung-Hun <komh78 <at> gmail.com>
Subject: Re: bug#19377: bug#19376: [PATCH 4/4] build: use -pi.bak instead of
 -pi
Date: Sun, 14 Dec 2014 07:23:38 -0800

On Sun, Dec 14, 2014 at 5:25 AM, Pádraig Brady <P <at> draigbrady.com> wrote:
> forcemerge 19376 19377
> stop
>
> On 14/12/14 03:47, KO Myung-Hun wrote:
>> This fixes the following error.
>>
>> -----
>> Can't do inplace edit without backup.
>> -----
>>
>> * Makefile.am (dist-hook): Use -pi.bak instead of -pi.
>> * bootstrap.conf (bootstrap_epilogue): Likewise.
>> ---
>>  Makefile.am    | 2 +-
>>  bootstrap.conf | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index fb4af27..371eb59 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -105,7 +105,7 @@ BUILT_SOURCES = .version
>>  # See the rm_subst comment for details.
>>  dist-hook: gen-ChangeLog
>>       $(AM_V_GEN)echo $(VERSION) > $(distdir)/.tarball-version
>> -     $(AM_V_at)perl -pi -e '$(rm_subst)' $(distdir)/Makefile.in
>> +     $(AM_V_at)perl -pi.bak -e '$(rm_subst)' $(distdir)/Makefile.in
>>
>>  gen_start_date = 2008-02-08
>>  .PHONY: gen-ChangeLog
>> diff --git a/bootstrap.conf b/bootstrap.conf
>> index c0b5f02..0baf455 100644
>> --- a/bootstrap.conf
>> +++ b/bootstrap.conf
>> @@ -366,7 +366,7 @@ bootstrap_epilogue()
>>    # Why?  That pipeline searches all files in $(top_srcdir), and if you
>>    # happen to have large files (or apparently large sparse files), the
>>    # first grep may well run out of memory.
>> -  perl -pi -e 's/if LC_ALL=C grep .GNU .PACKAGE.*; then/if true; then/' \
>> +  perl -pi.bak -e 's/if LC_ALL=C grep .GNU .PACKAGE.*; then/if true; then/' \
>>      po/Makefile.in.in
>>
>>    # Install our git hooks, as long as "cp" accepts the --backup option,
>
> This will leave .bak files in place on all platforms which isn't ideal.
> Pity `perl -i` doesn't handle the platform differences transparently.
> Does sed -i behave better. That's less portable though could be tried
> and then fall back to perl -i.

Actually, neither of those uses of perl -pi is run by one who builds
from a distribution tarball.  Only people who build from git and who
run "make dist" will run those commands, so I think it is fine to
require a working version of perl for those uses.

i.e., I would prefer not to incur the cost of ugly work-around
changes here for what appears to be a very "fringe" platform.

Message #21 received at 19377 <at> debbugs.gnu.org (full text, mbox):

From: KO Myung-Hun <komh78 <at> gmail.com>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 19377 <at> debbugs.gnu.org
Subject: Re: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du,
 head: support wildcards on OS/2
Date: Mon, 15 Dec 2014 10:15:56 +0900

Pádraig Brady wrote:
> forcemerge 19378 19377
> stop
> 
> On 14/12/14 03:47, KO Myung-Hun wrote:
>> And ln,ls,mv,rm,tail.
>>
>> * src/cat.c (main): Expand wildcards on OS/2.
>> * src/chcon.c (main): Likewise.
>> * src/chgrp.c (main): Likewise.
>> * src/chmod.c (main): Likewise.
>> * src/chown.c (main): Likewise.
>> * src/cp.c (main): Likewise.
>> * src/du.c (main): Likewise.
>> * src/head.c (main): Likewise.
>> * src/ln.c (main): Likewise.
>> * src/ls.c (main): Likewise.
>> * src/mv.c (main): Likewise.
>> * src/rm.c (main): Likewise.
>> * src/tail.c (main): Likewise.
>>
>> Patches from coreutils 8.8 by Paul Smedley.
> 
>> diff --git a/src/cat.c b/src/cat.c
>> index c7bb7e1..0138114 100644
>> --- a/src/cat.c
>> +++ b/src/cat.c
>> @@ -544,6 +544,10 @@ main (int argc, char **argv)
>>    bool show_tabs = false;
>>    int file_open_mode = O_RDONLY;
>>  
>> +#ifdef __OS2__
>> +  _wildcard (&argc, &argv);
>> +#endif
>> +
> 
> Interesing, the OS/2 shell doesn't doe the globbing.

Ported unixy shells(sh) support it, but OS/2 default shell(CMD) does not.

> I'm wondering about the scalability of this.
> Are there any facilities for dealing with arbitrary numbers
> of files, like with xargs for example?

No. It always processes all files.

> What are the practical limits of the number of files?

It's up to a free memory.

> Does _wildcard() exit with an error in this case?
> 

Call exit(255) with printing an error message.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

Message #24 received at 19377 <at> debbugs.gnu.org (full text, mbox):

From: KO Myung-Hun <komh78 <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 19377 <at> debbugs.gnu.org, Pádraig Brady <P <at> draigbrady.com>
Subject: Re: bug#19377: bug#19376: [PATCH 4/4] build: use -pi.bak instead
 of -pi
Date: Mon, 15 Dec 2014 10:26:48 +0900

Jim Meyering wrote:
> On Sun, Dec 14, 2014 at 5:25 AM, Pádraig Brady <P <at> draigbrady.com> wrote:
>> forcemerge 19376 19377
>> stop
>>
>> On 14/12/14 03:47, KO Myung-Hun wrote:
>>> This fixes the following error.
>>>
>>> -----
>>> Can't do inplace edit without backup.
>>> -----
>>>
>>> * Makefile.am (dist-hook): Use -pi.bak instead of -pi.
>>> * bootstrap.conf (bootstrap_epilogue): Likewise.
>>> ---
>>>  Makefile.am    | 2 +-
>>>  bootstrap.conf | 2 +-
>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Makefile.am b/Makefile.am
>>> index fb4af27..371eb59 100644
>>> --- a/Makefile.am
>>> +++ b/Makefile.am
>>> @@ -105,7 +105,7 @@ BUILT_SOURCES = .version
>>>  # See the rm_subst comment for details.
>>>  dist-hook: gen-ChangeLog
>>>       $(AM_V_GEN)echo $(VERSION) > $(distdir)/.tarball-version
>>> -     $(AM_V_at)perl -pi -e '$(rm_subst)' $(distdir)/Makefile.in
>>> +     $(AM_V_at)perl -pi.bak -e '$(rm_subst)' $(distdir)/Makefile.in
>>>
>>>  gen_start_date = 2008-02-08
>>>  .PHONY: gen-ChangeLog
>>> diff --git a/bootstrap.conf b/bootstrap.conf
>>> index c0b5f02..0baf455 100644
>>> --- a/bootstrap.conf
>>> +++ b/bootstrap.conf
>>> @@ -366,7 +366,7 @@ bootstrap_epilogue()
>>>    # Why?  That pipeline searches all files in $(top_srcdir), and if you
>>>    # happen to have large files (or apparently large sparse files), the
>>>    # first grep may well run out of memory.
>>> -  perl -pi -e 's/if LC_ALL=C grep .GNU .PACKAGE.*; then/if true; then/' \
>>> +  perl -pi.bak -e 's/if LC_ALL=C grep .GNU .PACKAGE.*; then/if true; then/' \
>>>      po/Makefile.in.in
>>>
>>>    # Install our git hooks, as long as "cp" accepts the --backup option,
>>
>> This will leave .bak files in place on all platforms which isn't ideal.
>> Pity `perl -i` doesn't handle the platform differences transparently.
>> Does sed -i behave better. That's less portable though could be tried
>> and then fall back to perl -i.
> 
> Actually, neither of those uses of perl -pi is run by one who builds
> from a distribution tarball.  Only people who build from git and who
> run "make dist" will run those commands, so I think it is fine to
> require a working version of perl for those uses.
> 

Yes, getting a working perl would be better.

> i.e., I would prefer not to incur the cost of ugly work-around
> changes here for what appears to be a very "fringe" platform.

Ah, ok. This is a destiny of a very "fringe" platform.

Thanks.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

Message #27 received at 19377 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: KO Myung-Hun <komh78 <at> gmail.com>
Cc: 19377 <at> debbugs.gnu.org
Subject: Re: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du,
 head: support wildcards on OS/2
Date: Mon, 15 Dec 2014 08:57:15 +0000

On 15/12/14 01:15, KO Myung-Hun wrote:
> 
> 
> Pádraig Brady wrote:
>> forcemerge 19378 19377
>> stop
>>
>> On 14/12/14 03:47, KO Myung-Hun wrote:
>>> And ln,ls,mv,rm,tail.
>>>
>>> * src/cat.c (main): Expand wildcards on OS/2.
>>> * src/chcon.c (main): Likewise.
>>> * src/chgrp.c (main): Likewise.
>>> * src/chmod.c (main): Likewise.
>>> * src/chown.c (main): Likewise.
>>> * src/cp.c (main): Likewise.
>>> * src/du.c (main): Likewise.
>>> * src/head.c (main): Likewise.
>>> * src/ln.c (main): Likewise.
>>> * src/ls.c (main): Likewise.
>>> * src/mv.c (main): Likewise.
>>> * src/rm.c (main): Likewise.
>>> * src/tail.c (main): Likewise.
>>>
>>> Patches from coreutils 8.8 by Paul Smedley.
>>
>>> diff --git a/src/cat.c b/src/cat.c
>>> index c7bb7e1..0138114 100644
>>> --- a/src/cat.c
>>> +++ b/src/cat.c
>>> @@ -544,6 +544,10 @@ main (int argc, char **argv)
>>>    bool show_tabs = false;
>>>    int file_open_mode = O_RDONLY;
>>>  
>>> +#ifdef __OS2__
>>> +  _wildcard (&argc, &argv);
>>> +#endif
>>> +
>>
>> Interesing, the OS/2 shell doesn't doe the globbing.
> 
> Ported unixy shells(sh) support it, but OS/2 default shell(CMD) does not.
> 
>> I'm wondering about the scalability of this.
>> Are there any facilities for dealing with arbitrary numbers
>> of files, like with xargs for example?
> 
> No. It always processes all files.
> 
>> What are the practical limits of the number of files?
> 
> It's up to a free memory.
> 
>> Does _wildcard() exit with an error in this case?
>>
> 
> Call exit(255) with printing an error message.
> 

While the adjustment is small, it would be better to avoid the ifdef in all programs.
I think there is a -Zwildcard option to auto enable for all programs?
Also is there an option to disable this expansion at runtime
(which should be documented if available).
For example to allow deleting a file called '*', which seems like a more likely
occurrence on this platform.

thanks,
Pádraig.

Message #30 received at 19377 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Pádraig Brady <P <at> draigbrady.com>
Cc: 19377 <19377 <at> debbugs.gnu.org>, KO Myung-Hun <komh78 <at> gmail.com>
Subject: Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod,
 chown, cp, du, head: support wildcards on OS/2
Date: Mon, 15 Dec 2014 06:59:38 -0800

On Mon, Dec 15, 2014 at 12:57 AM, Pádraig Brady <P <at> draigbrady.com> wrote:
> On 15/12/14 01:15, KO Myung-Hun wrote:
>>
>>
>> Pádraig Brady wrote:
>>> forcemerge 19378 19377
>>> stop
>>>
>>> On 14/12/14 03:47, KO Myung-Hun wrote:
>>>> And ln,ls,mv,rm,tail.
>>>>
>>>> * src/cat.c (main): Expand wildcards on OS/2.
>>>> * src/chcon.c (main): Likewise.
>>>> * src/chgrp.c (main): Likewise.
>>>> * src/chmod.c (main): Likewise.
>>>> * src/chown.c (main): Likewise.
>>>> * src/cp.c (main): Likewise.
>>>> * src/du.c (main): Likewise.
>>>> * src/head.c (main): Likewise.
>>>> * src/ln.c (main): Likewise.
>>>> * src/ls.c (main): Likewise.
>>>> * src/mv.c (main): Likewise.
>>>> * src/rm.c (main): Likewise.
>>>> * src/tail.c (main): Likewise.
>>>>
>>>> Patches from coreutils 8.8 by Paul Smedley.
>>>
>>>> diff --git a/src/cat.c b/src/cat.c
>>>> index c7bb7e1..0138114 100644
>>>> --- a/src/cat.c
>>>> +++ b/src/cat.c
>>>> @@ -544,6 +544,10 @@ main (int argc, char **argv)
>>>>    bool show_tabs = false;
>>>>    int file_open_mode = O_RDONLY;
>>>>
>>>> +#ifdef __OS2__
>>>> +  _wildcard (&argc, &argv);
>>>> +#endif
>>>> +
>>>
>>> Interesing, the OS/2 shell doesn't doe the globbing.
>>
>> Ported unixy shells(sh) support it, but OS/2 default shell(CMD) does not.
>>
>>> I'm wondering about the scalability of this.
>>> Are there any facilities for dealing with arbitrary numbers
>>> of files, like with xargs for example?
>>
>> No. It always processes all files.
>>
>>> What are the practical limits of the number of files?
>>
>> It's up to a free memory.
>>
>>> Does _wildcard() exit with an error in this case?
>>>
>>
>> Call exit(255) with printing an error message.
>>
>
> While the adjustment is small, it would be better to avoid the ifdef in all programs.
> I think there is a -Zwildcard option to auto enable for all programs?
> Also is there an option to disable this expansion at runtime
> (which should be documented if available).
> For example to allow deleting a file called '*', which seems like a more likely
> occurrence on this platform.

It would be better still not to modify so many programs directly.
Can you instead add one occurrence of that ifdef in system.h,
to change the definition of the initialize_main macro that is
already used from every main program?

Message #33 received at 19377 <at> debbugs.gnu.org (full text, mbox):

From: KO Myung-Hun <komh78 <at> gmail.com>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 19377 <at> debbugs.gnu.org
Subject: Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown,
 cp, du, head: support wildcards on OS/2
Date: Tue, 16 Dec 2014 11:00:10 +0900

Pádraig Brady wrote:
> On 15/12/14 01:15, KO Myung-Hun wrote:
>>
>>
>> Pádraig Brady wrote:
>>> forcemerge 19378 19377
>>> stop
>>>
>>> On 14/12/14 03:47, KO Myung-Hun wrote:
>>>> And ln,ls,mv,rm,tail.
>>>>
>>>> * src/cat.c (main): Expand wildcards on OS/2.
>>>> * src/chcon.c (main): Likewise.
>>>> * src/chgrp.c (main): Likewise.
>>>> * src/chmod.c (main): Likewise.
>>>> * src/chown.c (main): Likewise.
>>>> * src/cp.c (main): Likewise.
>>>> * src/du.c (main): Likewise.
>>>> * src/head.c (main): Likewise.
>>>> * src/ln.c (main): Likewise.
>>>> * src/ls.c (main): Likewise.
>>>> * src/mv.c (main): Likewise.
>>>> * src/rm.c (main): Likewise.
>>>> * src/tail.c (main): Likewise.
>>>>
>>>> Patches from coreutils 8.8 by Paul Smedley.
>>>
>>>> diff --git a/src/cat.c b/src/cat.c
>>>> index c7bb7e1..0138114 100644
>>>> --- a/src/cat.c
>>>> +++ b/src/cat.c
>>>> @@ -544,6 +544,10 @@ main (int argc, char **argv)
>>>>    bool show_tabs = false;
>>>>    int file_open_mode = O_RDONLY;
>>>>  
>>>> +#ifdef __OS2__
>>>> +  _wildcard (&argc, &argv);
>>>> +#endif
>>>> +
>>>
>>> Interesing, the OS/2 shell doesn't doe the globbing.
>>
>> Ported unixy shells(sh) support it, but OS/2 default shell(CMD) does not.
>>
>>> I'm wondering about the scalability of this.
>>> Are there any facilities for dealing with arbitrary numbers
>>> of files, like with xargs for example?
>>
>> No. It always processes all files.
>>
>>> What are the practical limits of the number of files?
>>
>> It's up to a free memory.
>>
>>> Does _wildcard() exit with an error in this case?
>>>
>>
>> Call exit(255) with printing an error message.
>>
> 
> While the adjustment is small, it would be better to avoid the ifdef in all programs.
> I think there is a -Zwildcard option to auto enable for all programs?

Good guess. -Zargs-wild.

> Also is there an option to disable this expansion at runtime
> (which should be documented if available).

What do you mean by 'at runtime' ? On command line ? Or a function
opposite to _wildcard() ?

In the former, escaping like unixy shells is used.

In the latter, no functions.

> For example to allow deleting a file called '*', which seems like a more likely
> occurrence on this platform.
> 

both '*' and '?' are illegal for a filename on OS/2.


-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

Message #36 received at 19377 <at> debbugs.gnu.org (full text, mbox):

From: KO Myung-Hun <komh78 <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 19377 <19377 <at> debbugs.gnu.org>,
 Pádraig Brady <P <at> draigbrady.com>
Subject: Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown,
 cp, du, head: support wildcards on OS/2
Date: Tue, 16 Dec 2014 11:34:28 +0900

[Message part 1 (text/plain, inline)]

Jim Meyering wrote:
> On Mon, Dec 15, 2014 at 12:57 AM, Pádraig Brady <P <at> draigbrady.com> wrote:
>> On 15/12/14 01:15, KO Myung-Hun wrote:
>>>
>>>
>>> Pádraig Brady wrote:
>>>> forcemerge 19378 19377
>>>> stop
>>>>
>>>> On 14/12/14 03:47, KO Myung-Hun wrote:
>>>>> And ln,ls,mv,rm,tail.
>>>>>
>>>>> * src/cat.c (main): Expand wildcards on OS/2.
>>>>> * src/chcon.c (main): Likewise.
>>>>> * src/chgrp.c (main): Likewise.
>>>>> * src/chmod.c (main): Likewise.
>>>>> * src/chown.c (main): Likewise.
>>>>> * src/cp.c (main): Likewise.
>>>>> * src/du.c (main): Likewise.
>>>>> * src/head.c (main): Likewise.
>>>>> * src/ln.c (main): Likewise.
>>>>> * src/ls.c (main): Likewise.
>>>>> * src/mv.c (main): Likewise.
>>>>> * src/rm.c (main): Likewise.
>>>>> * src/tail.c (main): Likewise.
>>>>>
>>>>> Patches from coreutils 8.8 by Paul Smedley.
>>>>
>>>>> diff --git a/src/cat.c b/src/cat.c
>>>>> index c7bb7e1..0138114 100644
>>>>> --- a/src/cat.c
>>>>> +++ b/src/cat.c
>>>>> @@ -544,6 +544,10 @@ main (int argc, char **argv)
>>>>>    bool show_tabs = false;
>>>>>    int file_open_mode = O_RDONLY;
>>>>>
>>>>> +#ifdef __OS2__
>>>>> +  _wildcard (&argc, &argv);
>>>>> +#endif
>>>>> +
>>>>
>>>> Interesing, the OS/2 shell doesn't doe the globbing.
>>>
>>> Ported unixy shells(sh) support it, but OS/2 default shell(CMD) does not.
>>>
>>>> I'm wondering about the scalability of this.
>>>> Are there any facilities for dealing with arbitrary numbers
>>>> of files, like with xargs for example?
>>>
>>> No. It always processes all files.
>>>
>>>> What are the practical limits of the number of files?
>>>
>>> It's up to a free memory.
>>>
>>>> Does _wildcard() exit with an error in this case?
>>>>
>>>
>>> Call exit(255) with printing an error message.
>>>
>>
>> While the adjustment is small, it would be better to avoid the ifdef in all programs.
>> I think there is a -Zwildcard option to auto enable for all programs?
>> Also is there an option to disable this expansion at runtime
>> (which should be documented if available).
>> For example to allow deleting a file called '*', which seems like a more likely
>> occurrence on this platform.
> 
> It would be better still not to modify so many programs directly.
> Can you instead add one occurrence of that ifdef in system.h,
> to change the definition of the initialize_main macro that is
> already used from every main program?

Good suggestion. I merged patch3 and patch4.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

[0001-build-expand-a-response-file-and-a-wildcard-on-OS-2.patch (text/plain, attachment)]

Message #39 received at 19377 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: KO Myung-Hun <komh78 <at> gmail.com>
Cc: 19377 <19377 <at> debbugs.gnu.org>,
 Pádraig Brady <P <at> draigbrady.com>
Subject: Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown,
 cp, du, head: support wildcards on OS/2
Date: Mon, 15 Dec 2014 20:22:50 -0800

KO Myung-Hun wrote:
>   /* Redirection and wildcarding when done by the utility itself.
>      Generally a noop, but used in particular for native VMS. */
>   #ifndef initialize_main
> -# define initialize_main(ac, av)
> +# ifndef __OS2__
> +#  define initialize_main(ac, av)
> +# else

What happened to VMS?  The comment doesn't seem to match the code, and this 
suggests that the code should be moved to wherever VMS does its thing.

Message #42 received at 19377 <at> debbugs.gnu.org (full text, mbox):

From: KO Myung-Hun <komh78 <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 19377 <19377 <at> debbugs.gnu.org>,
 Pádraig Brady <P <at> draigbrady.com>,
 Jim Meyering <jim <at> meyering.net>
Subject: Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown,
 cp, du, head: support wildcards on OS/2
Date: Tue, 16 Dec 2014 13:35:10 +0900

Paul Eggert wrote:
> KO Myung-Hun wrote:
>>   /* Redirection and wildcarding when done by the utility itself.
>>      Generally a noop, but used in particular for native VMS. */
>>   #ifndef initialize_main
>> -# define initialize_main(ac, av)
>> +# ifndef __OS2__
>> +#  define initialize_main(ac, av)
>> +# else
> 
> What happened to VMS?  The comment doesn't seem to match the code, and

I don't know of VMS. Do you mean to change comments for OS/2 ?

> this suggests that the code should be moved to wherever VMS does its thing.

Where is it ? I didn't find initialize_main() or others for VMS.


-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

Message #45 received at 19377 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: KO Myung-Hun <komh78 <at> gmail.com>
Cc: 19377 <19377 <at> debbugs.gnu.org>, Paul Eggert <eggert <at> cs.ucla.edu>,
 Pádraig Brady <P <at> draigbrady.com>
Subject: Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod,
 chown, cp, du, head: support wildcards on OS/2
Date: Mon, 15 Dec 2014 20:45:39 -0800

On Mon, Dec 15, 2014 at 8:35 PM, KO Myung-Hun <komh78 <at> gmail.com> wrote:
> Paul Eggert wrote:
>> KO Myung-Hun wrote:
>>>   /* Redirection and wildcarding when done by the utility itself.
>>>      Generally a noop, but used in particular for native VMS. */
>>>   #ifndef initialize_main
>>> -# define initialize_main(ac, av)
>>> +# ifndef __OS2__
>>> +#  define initialize_main(ac, av)
>>> +# else
>>
>> What happened to VMS?  The comment doesn't seem to match the code, and
>
> I don't know of VMS. Do you mean to change comments for OS/2 ?
>
>> this suggests that the code should be moved to wherever VMS does its thing.
>
> Where is it ? I didn't find initialize_main() or others for VMS.

It was never defined in any version-controlled file,
so please just update the comment, replacing VMS with OS/2.

Message #48 received at 19377 <at> debbugs.gnu.org (full text, mbox):

From: KO Myung-Hun <komh78 <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 19377 <19377 <at> debbugs.gnu.org>, Paul Eggert <eggert <at> cs.ucla.edu>,
 Pádraig Brady <P <at> draigbrady.com>
Subject: Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown,
 cp, du, head: support wildcards on OS/2
Date: Tue, 16 Dec 2014 14:11:16 +0900

[Message part 1 (text/plain, inline)]

Jim Meyering wrote:
> On Mon, Dec 15, 2014 at 8:35 PM, KO Myung-Hun <komh78 <at> gmail.com> wrote:
>> Paul Eggert wrote:
>>> KO Myung-Hun wrote:
>>>>   /* Redirection and wildcarding when done by the utility itself.
>>>>      Generally a noop, but used in particular for native VMS. */
>>>>   #ifndef initialize_main
>>>> -# define initialize_main(ac, av)
>>>> +# ifndef __OS2__
>>>> +#  define initialize_main(ac, av)
>>>> +# else
>>>
>>> What happened to VMS?  The comment doesn't seem to match the code, and
>>
>> I don't know of VMS. Do you mean to change comments for OS/2 ?
>>
>>> this suggests that the code should be moved to wherever VMS does its thing.
>>
>> Where is it ? I didn't find initialize_main() or others for VMS.
> 
> It was never defined in any version-controlled file,
> so please just update the comment, replacing VMS with OS/2.

Ok. Fixed.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

[0001-build-expand-a-response-file-and-a-wildcard-on-OS-2.patch (text/plain, attachment)]

Message #53 received at 19377-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: KO Myung-Hun <komh78 <at> gmail.com>
Cc: 19377-done <at> debbugs.gnu.org, Paul Eggert <eggert <at> cs.ucla.edu>,
 Pádraig Brady <P <at> draigbrady.com>
Subject: Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod,
 chown, cp, du, head: support wildcards on OS/2
Date: Thu, 18 Dec 2014 07:24:47 -0800

On Mon, Dec 15, 2014 at 9:11 PM, KO Myung-Hun <komh78 <at> gmail.com> wrote:
> Jim Meyering wrote:
>> On Mon, Dec 15, 2014 at 8:35 PM, KO Myung-Hun <komh78 <at> gmail.com> wrote:
>>> Paul Eggert wrote:
>>>> KO Myung-Hun wrote:
>>>>>   /* Redirection and wildcarding when done by the utility itself.
>>>>>      Generally a noop, but used in particular for native VMS. */
>>>>>   #ifndef initialize_main
>>>>> -# define initialize_main(ac, av)
>>>>> +# ifndef __OS2__
>>>>> +#  define initialize_main(ac, av)
>>>>> +# else
>>>>
>>>> What happened to VMS?  The comment doesn't seem to match the code, and
>>>
>>> I don't know of VMS. Do you mean to change comments for OS/2 ?
>>>
>>>> this suggests that the code should be moved to wherever VMS does its thing.
>>>
>>> Where is it ? I didn't find initialize_main() or others for VMS.
>>
>> It was never defined in any version-controlled file,
>> so please just update the comment, replacing VMS with OS/2.
>
> Ok. Fixed.

Thanks.
Pushed with minor grammar fixes in the commit log.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.