GNU bug report logs - #19377
[PATCH] OS/2 patches

Previous Next

Package: coreutils;

Reported by: KO Myung-Hun <komh78 <at> gmail.com>

Date: Sun, 14 Dec 2014 03:49:05 UTC

Severity: normal

Tags: fixed, patch

Merged with 19375, 19378

Done: Assaf Gordon <assafgordon <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Meyering <jim <at> meyering.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#19377: closed ([PATCH] OS/2 patches)
Date: Thu, 18 Dec 2014 15:26:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 18 Dec 2014 07:24:47 -0800
with message-id <CA+8g5KEiDKoFR1VT0ieBKNCLGx1NXO5xe3zQY-Bc=0FLZg+B+g <at> mail.gmail.com>
and subject line Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2
has caused the debbugs.gnu.org bug report #19377,
regarding [PATCH] OS/2 patches
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
19377: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19377
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: KO Myung-Hun <komh78 <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] OS/2 patches
Date: Sun, 14 Dec 2014 12:47:37 +0900
Hi/2.

These are OS/2 patches for coreutils.

Review, please...

[PATCH 1/4] doc: add $(EXEEXT) suffix to the executables
[PATCH 2/4] build: configure.ac: support a response file on OS/2
[PATCH 3/4] cat,chcon,chgrp,chmod,chown,cp,du,head: support wildcards
[PATCH 4/4] build: use -pi.bak instead of -pi


[Message part 3 (message/rfc822, inline)]
From: Jim Meyering <jim <at> meyering.net>
To: KO Myung-Hun <komh78 <at> gmail.com>
Cc: 19377-done <at> debbugs.gnu.org, Paul Eggert <eggert <at> cs.ucla.edu>,
 Pádraig Brady <P <at> draigbrady.com>
Subject: Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod,
 chown, cp, du, head: support wildcards on OS/2
Date: Thu, 18 Dec 2014 07:24:47 -0800
On Mon, Dec 15, 2014 at 9:11 PM, KO Myung-Hun <komh78 <at> gmail.com> wrote:
> Jim Meyering wrote:
>> On Mon, Dec 15, 2014 at 8:35 PM, KO Myung-Hun <komh78 <at> gmail.com> wrote:
>>> Paul Eggert wrote:
>>>> KO Myung-Hun wrote:
>>>>>   /* Redirection and wildcarding when done by the utility itself.
>>>>>      Generally a noop, but used in particular for native VMS. */
>>>>>   #ifndef initialize_main
>>>>> -# define initialize_main(ac, av)
>>>>> +# ifndef __OS2__
>>>>> +#  define initialize_main(ac, av)
>>>>> +# else
>>>>
>>>> What happened to VMS?  The comment doesn't seem to match the code, and
>>>
>>> I don't know of VMS. Do you mean to change comments for OS/2 ?
>>>
>>>> this suggests that the code should be moved to wherever VMS does its thing.
>>>
>>> Where is it ? I didn't find initialize_main() or others for VMS.
>>
>> It was never defined in any version-controlled file,
>> so please just update the comment, replacing VMS with OS/2.
>
> Ok. Fixed.

Thanks.
Pushed with minor grammar fixes in the commit log.


This bug report was last modified 6 years and 228 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.