GNU bug report logs - #19358
[PATCH 1/3] grep: use Aho-Corasick algorithm to search multiple fixed words

Previous Next

Full log

Message #16 received at 19358-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 19358-done <at> debbugs.gnu.org
Subject: Re: grep: use Aho-Corasick algorithm to search multiple fixed words
Date: Thu, 2 Jun 2016 15:45:27 -0700

[Message part 1 (text/plain, inline)]

Sorry that patch took so long to review. I installed it, along with the 
attached followup patches which are mostly just minor style things (plus 
fixing the attribution for a patch that I forgot to specify --author for).

I didn't get as much performance improvement on my platform, so I toned 
down the NEWS item a bit. Still, wow. It is a 2.5x performance 
improvement for that test case, and it's asymptotically better. Thanks.

[0001-grep-minor-cleanups-for-F-Aho-Corasick.patch (application/x-patch, attachment)]

[0002-grep-simplify-F-Aho-Corasick-a-bit.patch (application/x-patch, attachment)]

[0003-maint-correct-attribution.patch (application/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.