GNU bug report logs - #19357
[PATCH] grep: fails to build grep on a machine which has no PCRE with --enable-gcc-warnings

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19357 in the body.
You can then email your comments to 19357 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] grep: fails to build grep on a machine which has no PCRE with
 --enable-gcc-warnings
Date: Sat, 13 Dec 2014 00:53:47 +0900

[Message part 1 (text/plain, inline)]

If a machine has no PCRE, grep fails to build grep on it du to
-Werror=unused-variable with --enable-gcc-warnings.  I found it on
Fedora 21 (GCC 4.9.2).

$ ./configure --enable-gcc-warnings

$ make
make  all-recursive
make[1]: Entering directory '/usr/src/gnu/grep-2.21'
Making all in po
make[2]: Entering directory '/usr/src/gnu/grep-2.21/po'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/usr/src/gnu/grep-2.21/po'
Making all in lib
make[2]: Entering directory '/usr/src/gnu/grep-2.21/lib'
make  all-am
make[3]: Entering directory '/usr/src/gnu/grep-2.21/lib'
make[3]: Nothing to be done for 'all-am'.
make[3]: Leaving directory '/usr/src/gnu/grep-2.21/lib'
make[2]: Leaving directory '/usr/src/gnu/grep-2.21/lib'
Making all in doc
make[2]: Entering directory '/usr/src/gnu/grep-2.21/doc'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/usr/src/gnu/grep-2.21/doc'
Making all in src
make[2]: Entering directory '/usr/src/gnu/grep-2.21/src'
  CC       pcresearch.o
pcresearch.c:43:12: error: 'empty_match' defined but not used [-Werror=unused-variable]
 static int empty_match[2];
            ^
cc1: all warnings being treated as errors
Makefile:1314: recipe for target 'pcresearch.o' failed
make[2]: *** [pcresearch.o] Error 1
make[2]: Leaving directory '/usr/src/gnu/grep-2.21/src'
Makefile:1254: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/usr/src/gnu/grep-2.21'
Makefile:1195: recipe for target 'all' failed
make: *** [all] Error 2

[0001-grep-fails-to-build-grep-on-a-machine-which-has-no-P.patch (text/plain, attachment)]

Message #8 received at 19357 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 19357 <at> debbugs.gnu.org
Subject: Re: bug#19357: [PATCH] grep: fails to build grep on a machine which
 has no PCRE with --enable-gcc-warnings
Date: Fri, 12 Dec 2014 09:27:22 -0700

[Message part 1 (text/plain, inline)]

On 12/12/2014 08:53 AM, Norihiro Tanaka wrote:
> If a machine has no PCRE, grep fails to build grep on it du to
> -Werror=unused-variable with --enable-gcc-warnings.  I found it on
> Fedora 21 (GCC 4.9.2).
> 

> +++ b/NEWS
> @@ -2,6 +2,11 @@ GNU grep NEWS                                    -*- outline -*-
>  
>  * Noteworthy changes in release ?.? (????-??-??) [?]
>  
> +** Bug fixes
> +
> +  A warning is no longer output --enable-gcc-warnings even if build grep
> +  on a machine which has no PCRE.
> +  [bug introduced in grep-2.21]

I would not make this a NEWS item.  It is not a visible change in
behavior to the end user, only to the build process.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #11 received at 19357 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 19357 <at> debbugs.gnu.org
Subject: Re: bug#19357: [PATCH] grep: fails to build grep on a machine which
 has no PCRE with --enable-gcc-warnings
Date: Fri, 12 Dec 2014 08:54:22 -0800

[Message part 1 (text/plain, inline)]

On Fri, Dec 12, 2014 at 7:53 AM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> If a machine has no PCRE, grep fails to build grep on it du to
> -Werror=unused-variable with --enable-gcc-warnings.  I found it on
> Fedora 21 (GCC 4.9.2).
>
> $ ./configure --enable-gcc-warnings
>
> $ make
...
>   CC       pcresearch.o
> pcresearch.c:43:12: error: 'empty_match' defined but not used [-Werror=unused-variable]
>  static int empty_match[2];

Thank you. I've adjusted your patch (removed NEWS entry, modified commit message
to be more in line with our conventions), and will push shortly:

[0001-build-avoid-build-failure-with-enable-gcc-warnings-a.patch (application/octet-stream, attachment)]

Message #16 received at 19357-done <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Jim Meyering <jim <at> meyering.net>
Cc: 19357-done <at> debbugs.gnu.org
Subject: Re: bug#19357: [PATCH] grep: fails to build grep on a machine which
 has no PCRE with --enable-gcc-warnings
Date: Sat, 13 Dec 2014 08:56:45 +0900

On Fri, 12 Dec 2014 08:54:22 -0800
Jim Meyering <jim <at> meyering.net> wrote:
> Thank you. I've adjusted your patch (removed NEWS entry, modified commit message
> to be more in line with our conventions), and will push shortly:

Thanks for the review and push.  Closed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.