GNU bug report logs - #19357
[PATCH] grep: fails to build grep on a machine which has no PCRE with --enable-gcc-warnings

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#19357: closed ([PATCH] grep: fails to build grep on a machine
 which has no PCRE with --enable-gcc-warnings)
Date: Fri, 12 Dec 2014 23:57:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 13 Dec 2014 08:56:45 +0900
with message-id <20141213085644.BD04.27F6AC2D <at> kcn.ne.jp>
and subject line Re: bug#19357: [PATCH] grep: fails to build grep on a machine which has no PCRE with --enable-gcc-warnings
has caused the debbugs.gnu.org bug report #19357,
regarding [PATCH] grep: fails to build grep on a machine which has no PCRE with --enable-gcc-warnings
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
19357: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19357
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] grep: fails to build grep on a machine which has no PCRE with
 --enable-gcc-warnings
Date: Sat, 13 Dec 2014 00:53:47 +0900

[Message part 3 (text/plain, inline)]

If a machine has no PCRE, grep fails to build grep on it du to
-Werror=unused-variable with --enable-gcc-warnings.  I found it on
Fedora 21 (GCC 4.9.2).

$ ./configure --enable-gcc-warnings

$ make
make  all-recursive
make[1]: Entering directory '/usr/src/gnu/grep-2.21'
Making all in po
make[2]: Entering directory '/usr/src/gnu/grep-2.21/po'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/usr/src/gnu/grep-2.21/po'
Making all in lib
make[2]: Entering directory '/usr/src/gnu/grep-2.21/lib'
make  all-am
make[3]: Entering directory '/usr/src/gnu/grep-2.21/lib'
make[3]: Nothing to be done for 'all-am'.
make[3]: Leaving directory '/usr/src/gnu/grep-2.21/lib'
make[2]: Leaving directory '/usr/src/gnu/grep-2.21/lib'
Making all in doc
make[2]: Entering directory '/usr/src/gnu/grep-2.21/doc'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/usr/src/gnu/grep-2.21/doc'
Making all in src
make[2]: Entering directory '/usr/src/gnu/grep-2.21/src'
  CC       pcresearch.o
pcresearch.c:43:12: error: 'empty_match' defined but not used [-Werror=unused-variable]
 static int empty_match[2];
            ^
cc1: all warnings being treated as errors
Makefile:1314: recipe for target 'pcresearch.o' failed
make[2]: *** [pcresearch.o] Error 1
make[2]: Leaving directory '/usr/src/gnu/grep-2.21/src'
Makefile:1254: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/usr/src/gnu/grep-2.21'
Makefile:1195: recipe for target 'all' failed
make: *** [all] Error 2

[0001-grep-fails-to-build-grep-on-a-machine-which-has-no-P.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Jim Meyering <jim <at> meyering.net>
Cc: 19357-done <at> debbugs.gnu.org
Subject: Re: bug#19357: [PATCH] grep: fails to build grep on a machine which
 has no PCRE with --enable-gcc-warnings
Date: Sat, 13 Dec 2014 08:56:45 +0900

On Fri, 12 Dec 2014 08:54:22 -0800
Jim Meyering <jim <at> meyering.net> wrote:
> Thank you. I've adjusted your patch (removed NEWS entry, modified commit message
> to be more in line with our conventions), and will push shortly:

Thanks for the review and push.  Closed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.