GNU bug report logs - #19179
25.0.50; Build failure with wrong version in nt/emacs.rc

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Chris Zheng <chriszheng99 <at> gmail.com>
Subject: bug#19179: closed (Re: bug#19179: 25.0.50; Build failure with
 wrong version in nt/emacs.rc)
Date: Wed, 26 Nov 2014 02:31:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#19179: 25.0.50; Build failure with wrong version in nt/emacs.rc

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 19179 <at> debbugs.gnu.org.

-- 
19179: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19179
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 19179-done <at> debbugs.gnu.org
Subject: Re: bug#19179: 25.0.50;
 Build failure with wrong version in nt/emacs.rc
Date: Tue, 25 Nov 2014 21:30:25 -0500

I made hard going of this change. :(

[Message part 3 (message/rfc822, inline)]

From: Chris Zheng <chriszheng99 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; Build failure with wrong version in nt/emacs.rc
Date: Wed, 26 Nov 2014 00:02:35 +0800

With MSYS2/Mingw-w64 combination, compiling the master (HEAD 88871ef)
fails with:
windres -I . -O coff -o emacs.res emacs.rc
C:\msys64\mingw64\bin\windres.exe: emacs.rc:14: syntax error
Makefile:230: recipe for target 'emacs.res' failed
make[2]: *** [emacs.res] Error 1
make[2]: Leaving directory '/home/Kel/repo/emacs/nt'

It seems that `emacs.rc' goes wrong, since the line 14 looks like:
 FILEVERSION ,0,0
but it is expected to be:
 FILEVERSION 25,0,50,0

I think the problem comes from line 1917 in configure.ac, where
`$version' is null.  Although I know little about the configure, I
suspect changing `$version' to `$PACKAGE_VERSION' is OK.  That is, the
below patch.  Am I wrong?  I'm eager to know the solution.  Thank you.

___
	Modified   configure.ac
diff --git a/configure.ac b/configure.ac
index 6b6b1c7..0d12f85 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1914,7 +1914,7 @@ if test "${HAVE_W32}" = "yes"; then
     *) EMACS_MANIFEST="emacs-x86.manifest" ;;
   esac
   dnl Construct something of the form "24,4,0,0" with 4 components.
-  comma_version=`echo "$version.0.0" | sed -e 's/\./,/g' -e 's/^\([[^,]]*,[[^,]]*,[[^,]]*,[[^,]]*\).*/\1/'`
+  comma_version=`echo "$PACKAGE_VERSION.0.0" | sed -e 's/\./,/g' -e 's/^\([[^,]]*,[[^,]]*,[[^,]]*,[[^,]]*\).*/\1/'`
 
   comma_space_version=`echo "$comma_version" | sed 's/,/, /g'`
   AC_SUBST(comma_version)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.