GNU bug report logs - #19179
25.0.50; Build failure with wrong version in nt/emacs.rc

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19179 in the body.
You can then email your comments to 19179 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Chris Zheng <chriszheng99 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; Build failure with wrong version in nt/emacs.rc
Date: Wed, 26 Nov 2014 00:02:35 +0800

With MSYS2/Mingw-w64 combination, compiling the master (HEAD 88871ef)
fails with:
windres -I . -O coff -o emacs.res emacs.rc
C:\msys64\mingw64\bin\windres.exe: emacs.rc:14: syntax error
Makefile:230: recipe for target 'emacs.res' failed
make[2]: *** [emacs.res] Error 1
make[2]: Leaving directory '/home/Kel/repo/emacs/nt'

It seems that `emacs.rc' goes wrong, since the line 14 looks like:
 FILEVERSION ,0,0
but it is expected to be:
 FILEVERSION 25,0,50,0

I think the problem comes from line 1917 in configure.ac, where
`$version' is null.  Although I know little about the configure, I
suspect changing `$version' to `$PACKAGE_VERSION' is OK.  That is, the
below patch.  Am I wrong?  I'm eager to know the solution.  Thank you.

___
	Modified   configure.ac
diff --git a/configure.ac b/configure.ac
index 6b6b1c7..0d12f85 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1914,7 +1914,7 @@ if test "${HAVE_W32}" = "yes"; then
     *) EMACS_MANIFEST="emacs-x86.manifest" ;;
   esac
   dnl Construct something of the form "24,4,0,0" with 4 components.
-  comma_version=`echo "$version.0.0" | sed -e 's/\./,/g' -e 's/^\([[^,]]*,[[^,]]*,[[^,]]*,[[^,]]*\).*/\1/'`
+  comma_version=`echo "$PACKAGE_VERSION.0.0" | sed -e 's/\./,/g' -e 's/^\([[^,]]*,[[^,]]*,[[^,]]*,[[^,]]*\).*/\1/'`
 
   comma_space_version=`echo "$comma_version" | sed 's/,/, /g'`
   AC_SUBST(comma_version)

Message #10 received at 19179-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 19179-done <at> debbugs.gnu.org
Subject: Re: bug#19179: 25.0.50;
 Build failure with wrong version in nt/emacs.rc
Date: Tue, 25 Nov 2014 21:30:25 -0500

I made hard going of this change. :(

Message #15 received at 19179-done <at> debbugs.gnu.org (full text, mbox):

From: Chris Zheng <chriszheng99 <at> gmail.com>
To: rgm <at> gnu.org
Cc: 19179-done <at> debbugs.gnu.org
Subject: Re: bug#19179: 25.0.50; Build failure with wrong version in
 nt/emacs.rc
Date: Wed, 26 Nov 2014 12:02:46 +0800

From: Glenn Morris <rgm <at> gnu.org>
Subject: Re: bug#19179: 25.0.50; Build failure with wrong version in nt/emacs.rc
Date: Tue, 25 Nov 2014 21:30:25 -0500

> 
> I made hard going of this change. :(
> 
OK.  I known the problem is in my side.  Can you provide some hints
for solving the problem?  I search the `configure' file and find that
at line 18209 it has:
version=$PACKAGE_VERSION
so I want to use `$PACKAGE_VERSION' instead of `$version'.  Is is
expected to have a `version=25.0.50' line before `comma_version' is
calculated?  I have searched the list but no luck.

Thank you for your time.

Message #18 received at 19179-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Chris Zheng <chriszheng99 <at> gmail.com>
Cc: 19179-done <at> debbugs.gnu.org
Subject: Re: bug#19179: 25.0.50;
 Build failure with wrong version in nt/emacs.rc
Date: Tue, 25 Nov 2014 23:38:03 -0500

No, it was wrong, I changed it along the lines you said.

Message #21 received at 19179-done <at> debbugs.gnu.org (full text, mbox):

From: Chris Zheng <chriszheng99 <at> gmail.com>
To: rgm <at> gnu.org
Cc: 19179-done <at> debbugs.gnu.org
Subject: Re: bug#19179: 25.0.50; Build failure with wrong version in
 nt/emacs.rc
Date: Wed, 26 Nov 2014 15:01:14 +0800

From: Glenn Morris <rgm <at> gnu.org>
Subject: Re: bug#19179: 25.0.50; Build failure with wrong version in nt/emacs.rc
Date: Tue, 25 Nov 2014 23:38:03 -0500

> 
> No, it was wrong, I changed it along the lines you said.

Oh, it is fixed.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.