GNU bug report logs - #19044
'guix-register -p' should perform deduplication

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Subject: bug#19044: closed (Re: bug#19044: 'guix-register -p' should
 perform deduplication)
Date: Wed, 10 Jun 2015 12:14:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#19044: 'guix-register -p' should perform deduplication

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 19044 <at> debbugs.gnu.org.

-- 
19044: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19044
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: 19044-done <at> debbugs.gnu.org
Subject: Re: bug#19044: 'guix-register -p' should perform deduplication
Date: Wed, 10 Jun 2015 14:13:45 +0200

ludo <at> gnu.org (Ludovic Courtès) skribis:

> When used with -p (as is the case when building a disk/VM image),
> ‘guix-register’ doesn’t do any deduplication in the target store

Fixed in 3697558.

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: bug-guix <at> gnu.org
Subject: 'guix-register -p' should perform deduplication
Date: Thu, 13 Nov 2014 17:56:35 +0100

When used with -p (as is the case when building a disk/VM image),
‘guix-register’ doesn’t do any deduplication in the target store, as
noted in the source:

  /* XXX: When PREFIX is non-empty, store->linksDir points to the original
     store's '.links' directory, which means 'optimisePath' would try to link
     to that instead of linking to the target store.  Thus, disable
     deduplication in this case.  */
  if (optimize && prefix.empty ())
    {
      /* Make sure deduplication is enabled.  */
      settings.autoOptimiseStore = true;

      foreach (ValidPathInfos::const_iterator, i, infos)
	store->optimisePath (i->path);
    }

This should be fixed, but may need to diverge slightly from upstream
libstore.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.