GNU bug report logs - #19043
25.0.50; [PATCH]: faces for VC modeline state indicator

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19043 in the body.
You can then email your comments to 19043 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Óscar Fuentes <ofv <at> wanadoo.es>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; [PATCH]: faces for VC modeline state indicator
Date: Thu, 13 Nov 2014 17:39:16 +0100

[Message part 1 (text/plain, inline)]

2014-11-13 Oscar Fuentes <ofv <at> wanadoo.es>

	Add faces for the VC modeline state indicator.
	* lisp/vc/vc-hooks.el:
	(vc-state-faces, vc-state-base-face)
	(vc-up-to-date-state, vc-needs-update-state)
	(vc-locked-state, vc-locally-added-state)
	(vc-conflict-state, vc-removed-state)
	(vc-missing-state, vc-edited-state):
	New faces.
	(vc-default-mode-line-string): Use them

[vc-faces-upstream.patch (text/x-diff, attachment)]

Message #8 received at 19043 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Óscar Fuentes <ofv <at> wanadoo.es>
Cc: 19043 <at> debbugs.gnu.org
Subject: Re: bug#19043: 25.0.50; [PATCH]: faces for VC modeline state indicator
Date: Fri, 14 Nov 2014 05:18:02 +0100

Óscar Fuentes <ofv <at> wanadoo.es> writes:

> 2014-11-13 Oscar Fuentes <ofv <at> wanadoo.es>
>
> 	Add faces for the VC modeline state indicator.
> 	* lisp/vc/vc-hooks.el:
> 	(vc-state-faces, vc-state-base-face)
> 	(vc-up-to-date-state, vc-needs-update-state)
> 	(vc-locked-state, vc-locally-added-state)
> 	(vc-conflict-state, vc-removed-state)
> 	(vc-missing-state, vc-edited-state):
> 	New faces.
> 	(vc-default-mode-line-string): Use them

I tried applying this, but I didn't see anything different in the mode
lines of VC-covered files.  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 19043 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Óscar Fuentes <ofv <at> wanadoo.es>
Cc: 19043 <at> debbugs.gnu.org
Subject: Re: bug#19043: 25.0.50; [PATCH]: faces for VC modeline state indicator
Date: Fri, 14 Nov 2014 05:38:38 +0100

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

> Óscar Fuentes <ofv <at> wanadoo.es> writes:
>
>> 2014-11-13 Oscar Fuentes <ofv <at> wanadoo.es>
>>
>> 	Add faces for the VC modeline state indicator.
>> 	* lisp/vc/vc-hooks.el:
>> 	(vc-state-faces, vc-state-base-face)
>> 	(vc-up-to-date-state, vc-needs-update-state)
>> 	(vc-locked-state, vc-locally-added-state)
>> 	(vc-conflict-state, vc-removed-state)
>> 	(vc-missing-state, vc-edited-state):
>> 	New faces.
>> 	(vc-default-mode-line-string): Use them
>
> I tried applying this, but I didn't see anything different in the mode
> lines of VC-covered files.  

Oh, right.  All the faces remain as the default face, but the user can
customize them.  Perhaps they should be something else by default, too?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 19043 <at> debbugs.gnu.org (full text, mbox):

From: Óscar Fuentes <ofv <at> wanadoo.es>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 19043 <at> debbugs.gnu.org
Subject: Re: bug#19043: 25.0.50; [PATCH]: faces for VC modeline state indicator
Date: Fri, 14 Nov 2014 09:55:03 +0100

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

>> I tried applying this, but I didn't see anything different in the mode
>> lines of VC-covered files.  
>
> Oh, right.  All the faces remain as the default face, but the user can
> customize them.  Perhaps they should be something else by default, too?

I hope that just providing the possibility of customizing the VC
modeline face is seen as uncontroversial. Changing the default
appearance is something else altogether and it is not the goal of this
patch. You can assing different defaults on a subsequent patch, but
that's your battle, not mine ;-)

Message #17 received at 19043 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Óscar Fuentes <ofv <at> wanadoo.es>
Cc: 19043 <at> debbugs.gnu.org
Subject: Re: bug#19043: 25.0.50; [PATCH]: faces for VC modeline state indicator
Date: Fri, 14 Nov 2014 16:31:30 +0100

Óscar Fuentes <ofv <at> wanadoo.es> writes:

> I hope that just providing the possibility of customizing the VC
> modeline face is seen as uncontroversial. Changing the default
> appearance is something else altogether and it is not the goal of this
> patch. You can assing different defaults on a subsequent patch, but
> that's your battle, not mine ;-)

I think we should push defaults (since they are what will be used by
almost everyone) that are good.  (Or "best".)  Since you did this patch,
you probably think that the defaults could be better.  So I think we
should push a change that includes these better defaults...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #20 received at 19043 <at> debbugs.gnu.org (full text, mbox):

From: Óscar Fuentes <ofv <at> wanadoo.es>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 19043 <at> debbugs.gnu.org
Subject: Re: bug#19043: 25.0.50; [PATCH]: faces for VC modeline state indicator
Date: Fri, 14 Nov 2014 17:59:54 +0100

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

> I think we should push defaults (since they are what will be used by
> almost everyone) that are good.  (Or "best".)  Since you did this patch,
> you probably think that the defaults could be better.

That's true, I use values that are better *IMO*. Preparing the patch
consisted on removing those values for achieving a neutral impact on
appearance.

> So I think we should push a change that includes these better
> defaults...

In my experience, contributing a patch to Emacs is difficult enough when
only technical issues are considered. It is a nightmare when personal
opinion is a key part.

Please let's not block this feature just because it does not address an
orthogonal aspect that we can take care of later.

Just to convince you to stop asking me for default values, I'll mention
that on my setup edited files are shown with bright red text ;-)

Message #23 received at 19043 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Óscar Fuentes <ofv <at> wanadoo.es>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 19043 <at> debbugs.gnu.org
Subject: Re: bug#19043: 25.0.50; [PATCH]: faces for VC modeline state indicator
Date: Fri, 14 Nov 2014 12:08:09 -0500

> I hope that just providing the possibility of customizing the VC
> modeline face is seen as uncontroversial.

Very wise, indeed.
I think I'm OK with your proposed patch.


        Stefan

Message #26 received at 19043 <at> debbugs.gnu.org (full text, mbox):

From: Óscar Fuentes <ofv <at> wanadoo.es>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 19043 <at> debbugs.gnu.org
Subject: Re: bug#19043: 25.0.50; [PATCH]: faces for VC modeline state indicator
Date: Fri, 14 Nov 2014 18:18:11 +0100

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> I think I'm OK with your proposed patch.

Thanks. Now I need someone with a kind soul and commit rights for
applying the change.

Message #29 received at 19043 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Óscar Fuentes <ofv <at> wanadoo.es>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 19043 <at> debbugs.gnu.org
Subject: Re: bug#19043: 25.0.50; [PATCH]: faces for VC modeline state indicator
Date: Sun, 16 Nov 2014 15:14:09 +0100

Óscar Fuentes <ofv <at> wanadoo.es> writes:

> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>
>> I think I'm OK with your proposed patch.
>
> Thanks. Now I need someone with a kind soul and commit rights for
> applying the change.

I've applied it to trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #36 received at 19043 <at> debbugs.gnu.org (full text, mbox):

From: Óscar Fuentes <ofv <at> wanadoo.es>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 19043 <at> debbugs.gnu.org
Subject: Re: bug#19043: 25.0.50; [PATCH]: faces for VC modeline state indicator
Date: Sun, 16 Nov 2014 15:53:28 +0100

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

> Óscar Fuentes <ofv <at> wanadoo.es> writes:
>
>> Thanks. Now I need someone with a kind soul and commit rights for
>> applying the change.
>
> I've applied it to trunk.

Thank you Lars, but it was already applied by me. Now there is an extra
Changelog entry that you commit created. I'll delete it.

It is my fault for not closing the PR after the commit, sorry.

Message #39 received at 19043-done <at> debbugs.gnu.org (full text, mbox):

From: Óscar Fuentes <ofv <at> wanadoo.es>
To: 19043-done <at> debbugs.gnu.org
Subject: Re: bug#19043: 25.0.50; [PATCH]: faces for VC modeline state indicator
Date: Sun, 16 Nov 2014 15:54:10 +0100

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.