GNU bug report logs - #18951
24.4.51; eshell-pcomplete removes asterisk when attempting completion

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Daniel Kraus <daniel <at> kraus.my>, Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 18951 <at> debbugs.gnu.org
Subject: bug#18951: eshell-pcomplete removes asterisk when attempting completion
Date: Fri, 3 Nov 2017 23:25:34 +0200

On 11/2/17 4:15 PM, Daniel Kraus wrote:
> 
> Noam Postavsky <npostavs <at> users.sourceforge.net> writes:
> 
>> Hmm, does this do the right thing?
>>
>> --- i/lisp/pcomplete.el
>> +++ w/lisp/pcomplete.el
>> @@ -772,7 +772,7 @@ pcomplete-parse-arguments
>>   		(setq c (cdr c)))
>>   	      (setq pcomplete-stub (substring common-stub 0 len)
>>   		    pcomplete-autolist t)
>> -	      (when (and begin (not pcomplete-show-list))
>> +	      (when (and begin (> len 0) (not pcomplete-show-list))
>>   		(delete-region begin (point))
>>   		(pcomplete-insert-entry "" pcomplete-stub))
>>   	      (throw 'pcomplete-completions completions))
> 
> I didn't test it too much if something else breaks but it
> seems to work. pcomplete doesn't remove the * and company
> mode also seems to work without problems now.

Looking good in my testing, and fixes the problem. Thanks!

pcomplete-completion-at-point is still buggy, of course, but no worse 
than before.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.