GNU bug report logs - #18951
24.4.51; eshell-pcomplete removes asterisk when attempting completion

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18951 in the body.
You can then email your comments to 18951 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.51; eshell-pcomplete removes asterisk when attempting completion
Date: Wed, 05 Nov 2014 07:50:39 +0200

1. Open a new Eshell session.
2. Type `*'.
3. Press `TAB' (invoking `eshell-pcomplete'), or `M-x pcomplete', or
   `M-x completion-at-point'.
4. See the asterisk removed as the completions buffer is displayed.

I don't think it makes much sense (just replace it when a completion is
inserted), and it's quite inconvenient when
`pcomplete-completions-at-point' is used from company-mode during idle
completion, as reported here:
https://github.com/company-mode/company-mode/issues/218

In GNU Emacs 24.4.51.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2014-11-03 on axl
Repository revision: 117658 michael.albinus <at> gmx.de-20141102112256-548dk6al63uy76uh
Windowing system distributor `The X.Org Foundation', version 11.0.11501000
System Description:	Ubuntu 14.04.1 LTS

Message #8 received at 18951 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Kraus <daniel <at> kraus.my>
To: 18951 <at> debbugs.gnu.org
Subject: eshell-pcomplete removes asterisk when attempting completion
Date: Wed, 01 Nov 2017 12:16:57 +0800

Friendly bump.

The issue is now 3 years old, is there anything I can do to help get it fixed?
With all the new eshell hype I'm experimenting with switching more of my workflow
to eshell and would like instant company autocompleteion (instead of always using
(helm-)esh-pcomplete).

Thanks!

Message #11 received at 18951 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Daniel Kraus <daniel <at> kraus.my>
Cc: 18951 <at> debbugs.gnu.org
Subject: Re: bug#18951: eshell-pcomplete removes asterisk when attempting
 completion
Date: Wed, 01 Nov 2017 08:46:53 -0400

Daniel Kraus <daniel <at> kraus.my> writes:

> The issue is now 3 years old, is there anything I can do to help get
> it fixed?

A good start would be to step through eshell-pcomplete with edebug and
find the piece of code which deletes the asterisk.

Message #14 received at 18951 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Kraus <daniel <at> kraus.my>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 18951 <at> debbugs.gnu.org
Subject: Re: bug#18951: eshell-pcomplete removes asterisk when attempting
 completion
Date: Thu, 02 Nov 2017 15:00:00 +0800

[Message part 1 (text/plain, inline)]

Noam Postavsky <npostavs <at> users.sourceforge.net> writes:

> A good start would be to step through eshell-pcomplete with edebug and
> find the piece of code which deletes the asterisk.

It's in `pcomplete-parse-arguments` (in pcomplete.el)
Line 776 on master:
```
      (when (and begin (not pcomplete-show-list))
	(delete-region begin (point))
	(pcomplete-insert-entry "" pcomplete-stub))
```

Hope that helps.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 18951 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Daniel Kraus <daniel <at> kraus.my>
Cc: 18951 <at> debbugs.gnu.org
Subject: Re: bug#18951: eshell-pcomplete removes asterisk when attempting
 completion
Date: Thu, 02 Nov 2017 07:32:13 -0400

Daniel Kraus <daniel <at> kraus.my> writes:

> Noam Postavsky <npostavs <at> users.sourceforge.net> writes:
>
>> A good start would be to step through eshell-pcomplete with edebug and
>> find the piece of code which deletes the asterisk.
>
> It's in `pcomplete-parse-arguments` (in pcomplete.el)
> Line 776 on master:
> ```
>       (when (and begin (not pcomplete-show-list))
> 	(delete-region begin (point))
> 	(pcomplete-insert-entry "" pcomplete-stub))
> ```

Hmm, does this do the right thing?

--- i/lisp/pcomplete.el
+++ w/lisp/pcomplete.el
@@ -772,7 +772,7 @@ pcomplete-parse-arguments
 		(setq c (cdr c)))
 	      (setq pcomplete-stub (substring common-stub 0 len)
 		    pcomplete-autolist t)
-	      (when (and begin (not pcomplete-show-list))
+	      (when (and begin (> len 0) (not pcomplete-show-list))
 		(delete-region begin (point))
 		(pcomplete-insert-entry "" pcomplete-stub))
 	      (throw 'pcomplete-completions completions))

Message #20 received at 18951 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Kraus <daniel <at> kraus.my>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 18951 <at> debbugs.gnu.org
Subject: Re: bug#18951: eshell-pcomplete removes asterisk when attempting
 completion
Date: Thu, 02 Nov 2017 22:15:53 +0800

[Message part 1 (text/plain, inline)]

Noam Postavsky <npostavs <at> users.sourceforge.net> writes:

> Hmm, does this do the right thing?
>
> --- i/lisp/pcomplete.el
> +++ w/lisp/pcomplete.el
> @@ -772,7 +772,7 @@ pcomplete-parse-arguments
>  		(setq c (cdr c)))
>  	      (setq pcomplete-stub (substring common-stub 0 len)
>  		    pcomplete-autolist t)
> -	      (when (and begin (not pcomplete-show-list))
> +	      (when (and begin (> len 0) (not pcomplete-show-list))
>  		(delete-region begin (point))
>  		(pcomplete-insert-entry "" pcomplete-stub))
>  	      (throw 'pcomplete-completions completions))

I didn't test it too much if something else breaks but it
seems to work. pcomplete doesn't remove the * and company
mode also seems to work without problems now.

Thanks

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 18951 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Daniel Kraus <daniel <at> kraus.my>,
 Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 18951 <at> debbugs.gnu.org
Subject: Re: bug#18951: eshell-pcomplete removes asterisk when attempting
 completion
Date: Fri, 3 Nov 2017 23:25:34 +0200

On 11/2/17 4:15 PM, Daniel Kraus wrote:
> 
> Noam Postavsky <npostavs <at> users.sourceforge.net> writes:
> 
>> Hmm, does this do the right thing?
>>
>> --- i/lisp/pcomplete.el
>> +++ w/lisp/pcomplete.el
>> @@ -772,7 +772,7 @@ pcomplete-parse-arguments
>>   		(setq c (cdr c)))
>>   	      (setq pcomplete-stub (substring common-stub 0 len)
>>   		    pcomplete-autolist t)
>> -	      (when (and begin (not pcomplete-show-list))
>> +	      (when (and begin (> len 0) (not pcomplete-show-list))
>>   		(delete-region begin (point))
>>   		(pcomplete-insert-entry "" pcomplete-stub))
>>   	      (throw 'pcomplete-completions completions))
> 
> I didn't test it too much if something else breaks but it
> seems to work. pcomplete doesn't remove the * and company
> mode also seems to work without problems now.

Looking good in my testing, and fixes the problem. Thanks!

pcomplete-completion-at-point is still buggy, of course, but no worse 
than before.

Message #26 received at 18951 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Daniel Kraus <daniel <at> kraus.my>, 18951 <at> debbugs.gnu.org
Subject: Re: bug#18951: eshell-pcomplete removes asterisk when attempting
 completion
Date: Sun, 05 Nov 2017 12:17:27 -0500

tags 18951 fixed
close 18951 26.1
quit

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 11/2/17 4:15 PM, Daniel Kraus wrote:

>>> --- i/lisp/pcomplete.el
>>> +++ w/lisp/pcomplete.el
>>> @@ -772,7 +772,7 @@ pcomplete-parse-arguments
>>>   		(setq c (cdr c)))
>>>   	      (setq pcomplete-stub (substring common-stub 0 len)
>>>   		    pcomplete-autolist t)
>>> -	      (when (and begin (not pcomplete-show-list))
>>> +	      (when (and begin (> len 0) (not pcomplete-show-list))
>>>   		(delete-region begin (point))
>>>   		(pcomplete-insert-entry "" pcomplete-stub))
>>>   	      (throw 'pcomplete-completions completions))
>>
>> I didn't test it too much if something else breaks but it
>> seems to work. pcomplete doesn't remove the * and company
>> mode also seems to work without problems now.
>
> Looking good in my testing, and fixes the problem. Thanks!
> pcomplete-completion-at-point is still buggy, of course, but no worse
> than before.

Okay, pushed to emacs-26.

[1: 5d744e032f]: 2017-11-05 11:36:20 -0500
  Don't replace user input when completion prefix is empty (Bug#18951)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5d744e032fee9ce60446a3cc0cf7c2e681ace465>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.