GNU bug report logs - #18951
24.4.51; eshell-pcomplete removes asterisk when attempting completion

Previous Next

Full log

View this message in rfc822 format

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Daniel Kraus <daniel <at> kraus.my>
Cc: 18951 <at> debbugs.gnu.org
Subject: bug#18951: eshell-pcomplete removes asterisk when attempting completion
Date: Thu, 02 Nov 2017 07:32:13 -0400

Daniel Kraus <daniel <at> kraus.my> writes:

> Noam Postavsky <npostavs <at> users.sourceforge.net> writes:
>
>> A good start would be to step through eshell-pcomplete with edebug and
>> find the piece of code which deletes the asterisk.
>
> It's in `pcomplete-parse-arguments` (in pcomplete.el)
> Line 776 on master:
> ```
>       (when (and begin (not pcomplete-show-list))
> 	(delete-region begin (point))
> 	(pcomplete-insert-entry "" pcomplete-stub))
> ```

Hmm, does this do the right thing?

--- i/lisp/pcomplete.el
+++ w/lisp/pcomplete.el
@@ -772,7 +772,7 @@ pcomplete-parse-arguments
 		(setq c (cdr c)))
 	      (setq pcomplete-stub (substring common-stub 0 len)
 		    pcomplete-autolist t)
-	      (when (and begin (not pcomplete-show-list))
+	      (when (and begin (> len 0) (not pcomplete-show-list))
 		(delete-region begin (point))
 		(pcomplete-insert-entry "" pcomplete-stub))
 	      (throw 'pcomplete-completions completions))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.