GNU bug report logs - #18834
references to (long time removed) eww-quit

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18834: closed (references to (long time removed) eww-quit )
Date: Sun, 02 Nov 2014 21:04:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 02 Nov 2014 16:03:57 -0500
with message-id <87tx2hco1u.fsf <at> lifelogs.com>
and subject line Re: bug#18834: references to (long time removed) eww-quit
has caused the debbugs.gnu.org bug report #18834,
regarding references to (long time removed) eww-quit 
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18834: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18834
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ivan Shmakov <ivan <at> siamics.net>
To: submit <at> debbugs.gnu.org
Subject: references to (long time removed) eww-quit 
Date: Sat, 25 Oct 2014 16:47:43 +0000

[Message part 3 (text/plain, inline)]

Package:  emacs
Severity: minor
Tags:     patch

	Git records show eww-quit and eww-exit being defined and
	redefined the last December.  Ultimately, however, both of these
	commands were removed from the code, – yet the references to
	them remain there to this day.

	Please thus consider the (untested) patch MIMEd, which is
	intended to complete the following change:

commit 4c004eaa87a1c9771a3ad07b382efbb81e380f96
Author:     Lars Magne Ingebrigtsen <larsi <at> gnus.org>
AuthorDate: Sun Dec 1 18:00:04 2013 +0100

    eww: Have `q' do a normal `quit-window' instead of killing the buffer.

	TIA.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[Message part 4 (text/diff, inline)]

--- eww.el
+++ eww.el
@@ -443,7 +443,7 @@
 
     (easy-menu-define nil map ""
       '("Eww"
-	["Exit" eww-quit t]
+	["Exit" quit-window t]
 	["Close browser" quit-window t]
 	["Reload" eww-reload t]
 	["Back to previous page" eww-back-url
@@ -463,7 +463,7 @@
 (defvar eww-tool-bar-map
   (let ((map (make-sparse-keymap)))
     (dolist (tool-bar-item
-             '((eww-quit . "close")
+             '((quit-window . "close")
                (eww-reload . "refresh")
                (eww-back-url . "left-arrow")
                (eww-forward-url . "right-arrow")

[Message part 5 (message/rfc822, inline)]

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 18834-done <at> debbugs.gnu.org
Subject: Re: bug#18834: references to (long time removed) eww-quit
Date: Sun, 02 Nov 2014 16:03:57 -0500

On Sat, 25 Oct 2014 16:47:43 +0000 Ivan Shmakov <ivan <at> siamics.net> wrote: 

IS> -	["Exit" eww-quit t]
IS> +	["Exit" quit-window t]
IS> -             '((eww-quit . "close")
IS> +             '((quit-window . "close")

Thanks for the patch; applied in your name.  Closing.

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.