GNU bug report logs - #18834
references to (long time removed) eww-quit

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18834 in the body.
You can then email your comments to 18834 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Shmakov <ivan <at> siamics.net>
To: submit <at> debbugs.gnu.org
Subject: references to (long time removed) eww-quit 
Date: Sat, 25 Oct 2014 16:47:43 +0000

[Message part 1 (text/plain, inline)]

Package:  emacs
Severity: minor
Tags:     patch

	Git records show eww-quit and eww-exit being defined and
	redefined the last December.  Ultimately, however, both of these
	commands were removed from the code, – yet the references to
	them remain there to this day.

	Please thus consider the (untested) patch MIMEd, which is
	intended to complete the following change:

commit 4c004eaa87a1c9771a3ad07b382efbb81e380f96
Author:     Lars Magne Ingebrigtsen <larsi <at> gnus.org>
AuthorDate: Sun Dec 1 18:00:04 2013 +0100

    eww: Have `q' do a normal `quit-window' instead of killing the buffer.

	TIA.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[Message part 2 (text/diff, inline)]

--- eww.el
+++ eww.el
@@ -443,7 +443,7 @@
 
     (easy-menu-define nil map ""
       '("Eww"
-	["Exit" eww-quit t]
+	["Exit" quit-window t]
 	["Close browser" quit-window t]
 	["Reload" eww-reload t]
 	["Back to previous page" eww-back-url
@@ -463,7 +463,7 @@
 (defvar eww-tool-bar-map
   (let ((map (make-sparse-keymap)))
     (dolist (tool-bar-item
-             '((eww-quit . "close")
+             '((quit-window . "close")
                (eww-reload . "refresh")
                (eww-back-url . "left-arrow")
                (eww-forward-url . "right-arrow")

Message #10 received at 18834-done <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 18834-done <at> debbugs.gnu.org
Subject: Re: bug#18834: references to (long time removed) eww-quit
Date: Sun, 02 Nov 2014 16:03:57 -0500

On Sat, 25 Oct 2014 16:47:43 +0000 Ivan Shmakov <ivan <at> siamics.net> wrote: 

IS> -	["Exit" eww-quit t]
IS> +	["Exit" quit-window t]
IS> -             '((eww-quit . "close")
IS> +             '((quit-window . "close")

Thanks for the patch; applied in your name.  Closing.

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.