GNU bug report logs - #18777
[PATCH] dfa: improvement for checking of multibyte character boundary

Previous Next

Full log

Message #62 received at 18777 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <ADS18022 <at> nifty.com>
To: 18777 <at> debbugs.gnu.org
Cc: Paul Eggert <eggert <at> cs.ucla.edu>
Subject: Re: bug#18777: [PATCH] dfa: improvement for checking of multibyte
 character boundary
Date: Sat, 17 Jan 2015 10:54:21 +0900

[Message part 1 (text/plain, inline)]

On Fri, 19 Dec 2014 00:54:58 +0900
Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:

> On Thu, 18 Dec 2014 01:40:18 -0800
> Thanks, I understood that you said.  You are right.  I changed the patch
> so that always_character_boundary is not pruned even if WCP != NULL, and
> fixed the API document.

I fixed a mismatch with the comment.  It does not changes the behavior.
We expect that skip_remains_mb() is inlined, and "*WCP = WC" is merged
into "IF (P < MBP)" in caller.

--
+   exceeds P.  If WCP is non-NULL and the result is greater than p, set
+   *WCP to the final wide character processed, or if no wide character
+   is processed, set it to WEOF.  Both P and MBP must be no larger than
+   END.
    ........
-  if (wcp != NULL)
+  if (wcp != NULL && p < mbp)

[0001-dfa-improvement-for-checking-of-multibyte-character-.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.