GNU bug report logs - #18777
[PATCH] dfa: improvement for checking of multibyte character boundary

Previous Next

Full log

View this message in rfc822 format

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Eric Blake <eblake <at> redhat.com>, 18777 <at> debbugs.gnu.org
Subject: bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary
Date: Thu, 18 Dec 2014 02:21:30 +0900

On Tue, 16 Dec 2014 16:06:54 -0800
Paul Eggert <eggert <at> cs.ucla.edu> wrote:

> did you mean "robust in the presence of future changes? 

Yes.  However, I might have made too big a deal of the effect about
"Portable".

> True, but I wasn't worried so much about that. I was worried about the
> case where WCP != NULL: there, the inlined function will be slower
> because it won't use the faster approach of checking
> always_character_boundary[*p]: it'll always use the much-slower loop. 

If WCP != NULL, all of following code will be pruned, although I think
that it is ignorable for the performance.

  if (wcp == NULL && always_character_boundary[*p])
    return p;

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.